Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST IN HTTPS BECAUSE YOU CAN #19168

Closed
punuparcel4net opened this issue Feb 8, 2019 · 3 comments
Closed

REQUEST IN HTTPS BECAUSE YOU CAN #19168

punuparcel4net opened this issue Feb 8, 2019 · 3 comments

Comments

@punuparcel4net
Copy link

@punuparcel4net punuparcel4net commented Feb 8, 2019

  • I've verified and I assure that I'm running youtube-dl 2019.02.08
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description

Letting your application talk in HTTP in 2019 is absurd enough to be a bug.
Just a single extra letter “s” makes you secure. Why the hell not?

https://github.com/rg3/youtube-dl/blob/91effe22a091035bc5abace2fcf562a0db89090f/youtube_dl/extractor/pornhub.py#L169-L173

And this'll make @denotexist (#12722) happy, since they don't block HTTPS requests.

DO NOT IGNORE THIS ISSUE.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Feb 8, 2019

Does not make much difference since it's redirected to https version anyway.
Also nothing to do with #12722.

@dstftw dstftw closed this Feb 8, 2019
@alexvong1995
Copy link
Contributor

@alexvong1995 alexvong1995 commented Feb 8, 2019

@dstftw

Will patch to change to use HTTPS where possible be accepted? I've done similar
things in other project:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=98b90194d388b24fc1c0397dbc1b447e1e1ebd2d

IMO, we shouldn't depend on the site doing the right thing, as some may still
not have redirection enabled.

@punuparcel4net
Copy link
Author

@punuparcel4net punuparcel4net commented Feb 10, 2019

@dstftw

Does not make much difference since it's redirected to https version anyway.
Also nothing to do with #12722.

Yeah, thanks for the expected answer from you.
Don't you see #12722 happens because HTTP packets are visible?
Every HTTP packets to PornHub is blocked in the ISP level.

Are you seriously saying you don't give a fuck to your application's security, just because in your country it works no matter what?


@dstftw commented on Apr 16, 2017

Looks like pornhub is blocked by some Korean authorities:

And closing the issue tagging as invalid.

You did see what the problem was and you tagged it as invalid? What the hell was that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.