Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
REQUEST IN HTTPS BECAUSE YOU CAN #19168
Comments
|
Does not make much difference since it's redirected to https version anyway. |
|
Will patch to change to use HTTPS where possible be accepted? I've done similar IMO, we shouldn't depend on the site doing the right thing, as some may still |
Yeah, thanks for the expected answer from you. Are you seriously saying you don't give a fuck to your application's security, just because in your country it works no matter what?
And closing the issue tagging as You did see what the problem was and you tagged it as |
What is the purpose of your issue?
Description
Letting your application talk in HTTP in 2019 is absurd enough to be a bug.
Just a single extra letter “
s” makes you secure. Why the hell not?https://github.com/rg3/youtube-dl/blob/91effe22a091035bc5abace2fcf562a0db89090f/youtube_dl/extractor/pornhub.py#L169-L173
And this'll make @denotexist (#12722) happy, since they don't block HTTPS requests.
DO NOT IGNORE THIS ISSUE.