Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Accept-Encoding header for DASH/M3U8 playlist requests for Youtube Live streams #19191

Closed
jmf1988 opened this issue Feb 11, 2019 · 2 comments
Closed

Comments

@jmf1988
Copy link

@jmf1988 jmf1988 commented Feb 11, 2019

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • [ x] I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

  • [x ] At least skimmed through the README, most notably the FAQ and BUGS sections
  • [ x] Searched the bugtracker for similar issues including closed ones
  • [ x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • [x ] Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

I noticied after many tests that for long live streams with backbuffer enabled each requests to download hls playlists and dash manifests uncompressed eat sometimes way more bandwidth that the actual segments on low/medium quality live streams because the list is too long, this hurt in latency and performance is just unreallistic for live media, and, because this can be avoided by adding the "Accept-Encoding: gzip" header on requests to the manifest/playlist only to any downloader or ffmpeg, I am requesting to reenable the header by default, at least only for m3u8 protocol. Thank you.

@jmf1988 jmf1988 changed the title Enable Accept-Encoding header for manifest requests on Youtube Live streams Enable Accept-Encoding header for DASH/M3U8 playlist requests for Youtube Live streams Feb 11, 2019
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Feb 11, 2019

Live HLS is handled by ffmpeg. Which headers it will send is out of control of youtube-dl.
https://trac.ffmpeg.org/ticket/7158

@dstftw dstftw closed this Feb 11, 2019
@jmf1988
Copy link
Author

@jmf1988 jmf1988 commented Feb 11, 2019

Live HLS is handled by ffmpeg. Which headers it will send is out of control of youtube-dl.
https://trac.ffmpeg.org/ticket/7158

Then why if I comment the line 1971 in youtube.py it pass the header to ffmpeg ?
The line above that says that was disabled for causing failures, which is too vague, does not say which failure and where.
I know is a bug of ffmpeg, but ffmpeg is not a youtube specific tool and if it can be fixed by just passing a header why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.