Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
YouTube video description breaks JSON parsing #19228
Comments
|
I performed some review of this issue. I verified the given case and am able to make a stronger conclusion about the source. The JSON parsing at question is in extractor/Common.py _parse_json() After analyzing the json string I can say the following. The only resolution to this in my mind would be to manually verify all incoming json for erroneous escape sequences which has performance implications and is not necessary in the majority of cases. I will continue to check out the issue and see if I can confirm the original source of the encoding error. |
|
Thanks for your help! |
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like this:[x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the
-vflag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):Description of your issue, suggested solution and other information
I found out the issue that was causing #17940. The description of the video contains escape characters and breaks the JSON parsing. While it doesn't cause a failure in simply downloading the video, if it's deep in watch history, it will (as shown in #17940).