Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nicer warning message for: Requested formats are incompatible for merge and will be merged into mkv #19267

Open
JensKorte opened this issue Feb 18, 2019 · 2 comments

Comments

@JensKorte
Copy link

@JensKorte JensKorte commented Feb 18, 2019

  • I've verified and I assure that I'm running youtube-dl 2019.02.18
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Other

Description of your issue, suggested solution and other information

The warning message "WARNING: Requested formats are incompatible for merge and will be merged into mkv." is not easy to understand when reading it for the first time: "are incompatible for merge and will be merged".

Could you please extend the warning to something like:

  • WARNING: Requested formats are incompatible for direct merge and will be merged into mkv.
  • WARNING: Requested formats are incompatible for merge in the video format/video container and will be merged into mkv.
  • WARNING: Requested formats cannot be merged in one of themselfs themselves and will be merged into a mkv container.
  • WARNING: Requested formats cannot be merged into one of themselfs themselves and will be merged into mkv.

(Edited after reading comment from rautamiekka)

@rautamiekka
Copy link

@rautamiekka rautamiekka commented Feb 18, 2019

If WARNING: Requested formats are incompatible for merge in the video format/video container and will be merged into mkv. was to be chosen, I'd expand it to say merging into the specified video format/video container.

In the last 2 ones themselfs is a violation and should be themselves. In fact the in one of doesn't make sense, not sure if it's a violation.

@JensKorte
Copy link
Author

@JensKorte JensKorte commented Feb 19, 2019

If WARNING: Requested formats are incompatible for merge in the video format/video container and will be merged into mkv. was to be chosen, I'd expand it to say merging into the specified video format/video container.

I would prefer "selected" because it is easier, but I don't know which one is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.