Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When 'nooverwrites' is set, YoutubeDL should not overwrite descriptions, info.json, thumbnails and subtitles #1980

Closed
alimirjamali opened this issue Dec 15, 2013 · 3 comments

Comments

@alimirjamali
Copy link
Contributor

@alimirjamali alimirjamali commented Dec 15, 2013

Dear @phihag , @jaimeMF

I believe when the -w or --no-overwrites option is used and 'nooverwrites' is set within YoutubeDL.py; then it should not overwrite .description, .info.json, thumbnail and subtitles.

If user does not want to overwrite, He/She does not really want to overwrite a single file. Not just the actual Video.

I can fork YoutubeDL.py and submit suggested changes. Please let me know if you agree.

Sincerely yours,
Ali

@alimirjamali
Copy link
Contributor Author

@alimirjamali alimirjamali commented Dec 15, 2013

Just for example, Imagine the case that a programmer or user wants to add custom comments to descriptions or json files. They are all overwritten. This is not good.

@phihag
Copy link
Contributor

@phihag phihag commented Dec 16, 2013

You make a good point. I have changed the behavior in youtube-dl 2013.12.16.

@phihag phihag closed this in 7b6fefc Dec 16, 2013
@alimirjamali
Copy link
Contributor Author

@alimirjamali alimirjamali commented Dec 16, 2013

Thank you very much.

I wish you in advance a Merry Christmas and a Happy new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.