Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report url of downloading video in progress hook #20579

Closed
bbappserver opened this issue Apr 6, 2019 · 1 comment
Closed

Report url of downloading video in progress hook #20579

bbappserver opened this issue Apr 6, 2019 · 1 comment

Comments

@bbappserver
Copy link

@bbappserver bbappserver commented Apr 6, 2019

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.04.01. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2019.04.01

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

youtube-dl should report the url it's operating on in the python progress hooks.
When the calling process cannot always determine the url because sometimes youtube-dl is used to process playlists. However the calling process may need to collect the page url, and perhaps the url of the actual video stream.


Description of your issue, suggested solution and other information

youtube-dl should report the url it's operating on in the python progress hooks.
When the calling process cannot always determine the url because sometimes youtube-dl is used to process playlists. However the calling process may need to collect the page url, and perhaps the url of the actual video stream.

Simply add a two items to progress hooks:

  • page_url:The page in which the currently downloaded media was embed
  • data_url: The network location of the media backing the player embedded in the page (if applicable)
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 6, 2019

Progress hook is supposed to deliver downloading progress information not metadata. Any video metadata must be extracted separately if needed.

@dstftw dstftw closed this Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.