Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key 's' vs 'sig' in url_data causing some video downloads to fail #2062

Closed
sixteenornumber opened this issue Dec 30, 2013 · 3 comments
Closed

key 's' vs 'sig' in url_data causing some video downloads to fail #2062

sixteenornumber opened this issue Dec 30, 2013 · 3 comments

Comments

@sixteenornumber
Copy link

@sixteenornumber sixteenornumber commented Dec 30, 2013

I started modifying the youtube-dl i have 2012.02.27 to accept certain failed youtube videos but then asked myself, "is someone already doing this?" any and all videos i've tried to DL from "vivo" IE: http://www.youtube.com/watch?v=KoPlkmYaEQs all fail!

the specific line that starts the failure is,
[code]
url_map = dict((ud['itag'][0], ud['url'][0] + '&signature=' + ud['sig'][0]) for ud in url_data)
[/code]

As far as i can tell, the data within url_data is exactly the same, but they have changed the key to 's' vs the 'sig' that youtube-dl is looking for. I don't really know what the github procedure is on this but assuming no one is working on this, I'd be glad to continue with the fix.

@xubuntu4iran
Copy link

@xubuntu4iran xubuntu4iran commented Dec 30, 2013

put your output with -v option
update to latest version: 2013.12.26

@phihag
Copy link
Contributor

@phihag phihag commented Dec 30, 2013

Your version of youtube-dl is totally out of date. Type youtube-dl -U (or git pull) to update. If you got your version of youtube-dl from a distribution, contact the distribution's maintainer for youtube-dl and ask for an update.

If something fails after the update, please file a bug (or better, pull request) so that everyone else profits from your changes. Make sure to include the complete output of youtube-dl when called with the -v option.

I'm closing this issue now since VEVO video downloads work fine with a current version.

@phihag phihag closed this Dec 30, 2013
@sixteenornumber
Copy link
Author

@sixteenornumber sixteenornumber commented Dec 30, 2013

Then the default repos for Ubuntu are out of date too. Thanks guys
On Dec 30, 2013 11:58 PM, "xubuntu4iran" notifications@github.com wrote:

put your output with -v option
update to latest version: 2013.12.26


Reply to this email directly or view it on GitHubhttps://github.com//issues/2062#issuecomment-31347775
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.