Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
key 's' vs 'sig' in url_data causing some video downloads to fail #2062
Comments
|
put your output with -v option |
|
Your version of youtube-dl is totally out of date. Type If something fails after the update, please file a bug (or better, pull request) so that everyone else profits from your changes. Make sure to include the complete output of youtube-dl when called with the I'm closing this issue now since VEVO video downloads work fine with a current version. |
|
Then the default repos for Ubuntu are out of date too. Thanks guys
|
I started modifying the youtube-dl i have 2012.02.27 to accept certain failed youtube videos but then asked myself, "is someone already doing this?" any and all videos i've tried to DL from "vivo" IE: http://www.youtube.com/watch?v=KoPlkmYaEQs all fail!
the specific line that starts the failure is,
[code]
url_map = dict((ud['itag'][0], ud['url'][0] + '&signature=' + ud['sig'][0]) for ud in url_data)
[/code]
As far as i can tell, the data within url_data is exactly the same, but they have changed the key to 's' vs the 'sig' that youtube-dl is looking for. I don't really know what the github procedure is on this but assuming no one is working on this, I'd be glad to continue with the fix.