Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfycat.com url changes #20696

Closed
jamesxmcintosh opened this issue Apr 17, 2019 · 1 comment
Closed

gfycat.com url changes #20696

jamesxmcintosh opened this issue Apr 17, 2019 · 1 comment

Comments

@jamesxmcintosh
Copy link

@jamesxmcintosh jamesxmcintosh commented Apr 17, 2019

  • I've verified and I assure that I'm running youtube-dl 2019.04.17

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

gfycat.com has added dashes to some urls https://gfycat.com/acceptablehappygoluckyharborporpoise-baseball causing a HTTP Error.
This could be fixed by excluding dashes in the url InfoExtractor.

@Hrxn
Copy link

@Hrxn Hrxn commented Apr 17, 2019

Isn't this some kind of hint, or a tag, or a file name if you want?

Because the scheme for the ID still seems the same, i.e. it should work as before.
What happens if you remove that part behind the hyphen (and the hyphen)?
I'd guess it will still work just as before.

Edit:

Yeah, should have looked at the commit before. You just changed the regex to ignore this part.

@dstftw dstftw closed this in 68b92aa May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.