Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Support multiple audio tracks / languages for southpark.de #21271
Comments
|
Post concrete example URLs. |
|
Sorry. I concluded that this wasn't nessesary since the topic concerns the whole site along with every video as far as I know. But the issue description requirements are worded very precise. Example URLs: |
|
Sorry, i don't follow. And: Does youtube-dl currently have any infrastructure to support multiple audio tracks in one video? |
|
Is your code only able to get the cookie if downloading an url under
And also the commentaries which are only offered with english audio: Also this change seems pretty simple, as all necessary extractor work is already implemented and this is only a question of specifying the correct language. Would it be safe to implement this for all southpark extractors of all country divisions since they're all using the same backend? |
|
N.B. on the requirement of example URLs: Only now i start to grasp the workflow of a youtube-dl developer and the role of example URLs and why they always should be provided. This reminds me of #18303 where the user Siddhant suggested to change an error message for users who don't get it. Maybe i'm the only one who didn't get it with the example URLs but if this happens often i hope changing the relevant paragraph will be considered. |
In my opinion, this is not correct. Every properly implemented extractor has a host of test cases representing known "good" cases. These tests can and should be run, in order to avoid regressions. Unless you're trying to improve a known restricted extractor, you shouldn't be forced to provide previously good cases. The problem is: I have stumbled across this myself, when trying to improve extractors. (Improving them myself meaning: Fix or amend the python code, test with my particular use case, and try to create a PR (pull request).) My impression was (don't take this as full fact): Some testcases are outdated, some actually don't work anymore, some require a login (but AFAICT the test infrastructure doesn't allow for providing login credentials, while the CLI does), some of the checked details have changed but have never been updated... So before fixing something, I need to go through the existing tests first. Oh, and I haven't found a way to say "run all tests", they apparently need to be specified with "_1", "_2", "_3". This makes it very tedious, and the benefit of the test cases becomes slightly questionable. Sorry for this rant. youtube-dl is an excellent tool, and I'm impressed by its quality and how much progress it makes with limited developer time. These issues of mine belong in a separate ticket. I'm just trying to say: You probably needn't have worried about providing existing URLs. |
Checklist
Description
The Problem is: southpark.de is offering its video content with two audio languages. First off english, as it is the original language of the series. Then in german as this is the country at which southpark.de is addressed to. When using the website to play a video, the language can be switched using a combination of javascript buttons which causes the wesite to reload and switch to the selected audio track.
When using youtube-dl to download a video from southpark.de, there is no option (at least none that i could find) to select which audio tracks are downloaded - downloading with youtube-dl yields a video with just the local language audio track (in this case german).
This could be fixed by finding a way to download the english audio track.
My proposed solution would look this way: When downloading a video from southpark.de that is being offered in multiple languages, youtube-dl will output a video file with all available languages as seperate audio tracks embedded into it.
Ideally, this should be done in a way so that it applies to all southpark sites for all countries, but this will sadly be impossible to test properly without proxies or similar since any southpark site always redirects to it's local site due to georestriction.