Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support downloading multiple subtitle formats of the same language at once #21345

Open
altimumdelta opened this issue Jun 9, 2019 · 1 comment
Labels

Comments

@altimumdelta
Copy link

@altimumdelta altimumdelta commented Jun 9, 2019

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2019.06.08
  • I've searched the bugtracker for similar feature requests including closed ones

Description

I first thought this is a bug, but then I changed my mind based on some educated guessing, I may be wrong.

I have manually checked and ttml is downloadable fine from the YT videos I'm downloading in this case.

--all-subs doesn't seem to do it, it apparently applies only to "all languages" in this case it's only english, and it takes a format it thinks it's most appropriate, vtt.

--sub-format only takes in one valid format or a preference, it does not support comma separated multiple values.

These options should be renamed as they feel too vague and it's not clear whether --all-subs should be used with --write-sub or not, lack of context.

It could be --sub-formats to reflect it could accept commas, or a new option --all-sub-formats
Additionally --all-subs should be renamed to --all-sub-langs , but it's already inconsitent because I found out --all-subs doesn't need --write-sub so from the name it seems as an optional secondary option but it is infact a standalone command which means it should be called --write-all-sub-langs, however I thought that "write" meant baking it into the file with ffmpeg or even into the video it self, maybe get or save could be a better term, but it's not that big deal.

However it should be named appropriately so that it wouldn't conflict with exactly that idea of merging/packing the subs into a supported container described here: #21344
Still, those terms would rather be "pack" "merge" so it may not be an issue.

--
Currently it's only practically possible downloading other subtitle formats in a separate session with
--skip-download option.

@altimumdelta altimumdelta added the request label Jun 9, 2019
@RevSnowfox
Copy link

@RevSnowfox RevSnowfox commented Jun 17, 2019

I vouch for this, it would be nice to be able to download several formats of subtitles, most importantly YouTube's own SRV3 format for archival purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.