Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to keep original subtitles file after conversion (or update readme) #21424

Open
section83 opened this issue Jun 17, 2019 · 0 comments
Open
Labels

Comments

@section83
Copy link

@section83 section83 commented Jun 17, 2019

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2019.06.08
  • I've searched the bugtracker for similar feature requests including closed ones

Description

Currently, there is no specific option to keep the original subtitles file after a conversion. It is deleted by default. Nonetheless, the original subtitles file can be retained if the "--keep-video" option is used – this doesn't seem to be documented. However, that will cause the original video file to be kept if remuxing is also specified. It doesn't seem possible to keep the original video file but not the original subtitles files and vice-versa.

A separate "keep original subtitles file" option would address this. However, I guess FFmpeg might not have a separate option for this so, alternatively, the readme.md could be altered to make clear that the original video and subtitles files will be kept. That is, "--keep-video" will keep the original subtitles file after conversion and/or the original video file after remuxing.

@section83 section83 added the request label Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.