Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape & character in ttml (xml) subtitles #21894

Closed
Diegus83 opened this issue Jul 25, 2019 · 1 comment
Closed

Properly escape & character in ttml (xml) subtitles #21894

Diegus83 opened this issue Jul 25, 2019 · 1 comment

Comments

@Diegus83
Copy link

@Diegus83 Diegus83 commented Jul 25, 2019

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2019.07.16
  • I've searched the bugtracker for similar feature requests including closed ones

Description

WRITE DESCRIPTION HERE

I recently downloaded some subtitles from Discovery and they come with a ttml extension, internally being just XML files.

After manually inspecting one that failed to convert to srt using different tools, the culprit was an & symbol not escaped properly &

<p region="pop317" begin="00:07:40.133" end="00:07:45.800"><span tts:backgroundColor="black" tts:color="white">BACK AT MASELLI & SONS.</span></p>

I have no way to verify if the file was malformed on the server or this was an error when youtube-dl wrote the output file but maybe checking for properly escaped XML files is something that can be added to youtube-dl when an XML subtitle is downloaded.

Complete xml file is here https://pastebin.com/pVw1pb7p

@Diegus83 Diegus83 added the request label Jul 25, 2019
@dstftw dstftw closed this Jul 25, 2019
@dstftw dstftw added the incomplete label Jul 25, 2019
@Diegus83
Copy link
Author

@Diegus83 Diegus83 commented Jul 25, 2019

Is there any information I missed? Or is this request outside the scope of the project?
I would just like to know.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.