Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce prevention downloading same file #22120

Closed
brutalcrozt opened this issue Aug 16, 2019 · 4 comments
Closed

Enforce prevention downloading same file #22120

brutalcrozt opened this issue Aug 16, 2019 · 4 comments
Labels

Comments

@brutalcrozt
Copy link

@brutalcrozt brutalcrozt commented Aug 16, 2019

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2019.08.13
  • I've searched the bugtracker for similar feature requests including closed ones

I am not sure if this is feature request, it's 2019.07.30 that i use

this is the full info
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.07.30
[debug] Python version 2.7.12 (CPython) - Linux-4.15.0-58-generic-x86_64-with-LinuxMint-18.3-sylvia
[debug] exe versions: ffmpeg 2.8.15, ffprobe 2.8.15
[debug] Proxy map: {}
Usage: youtube-dl [OPTIONS] URL [URL...]

youtube-dl: error: You must provide at least one URL.
## Description
  • What the problem is
    Screenshot from 2019-08-16 14-16-11(yt change desiredoutput)
    It already downloaded the x.webm file, but it repeats download again and unfortunately changes to x.mp4

Screenshot from 2019-08-16 16-12-40(yt not aware on existing mp3 file)
This one is youtube-dl output-ed to mp3

Screenshot from 2019-08-16 20-22-14(yt dl mp3)
this one is to re-confirm the youtube-dl output-ed to mp3

  • How it could be fixed
    Firstly, it's my suspicion that 1. we do check with the desired vidio.extension. While i am proposing we do check existing downloaded file with only the video name, without extension.
    Also, it should be the same, regardless of the desired file output.
    Having said that, i never know or read about the video or output quality.
  1. FYI those above behavior is not use --download-archive option
  • How your proposed solution would look like
    Always check existing file first, with file default video name as it's the file name and without the file extension.

Related to point 1, can we just make the default youtube-dl behavior when using --yes-playlist use --download-archive with a default file name. IE playlist_id.txt.

I think it can be tackle down with #16790
not use download archive

@brutalcrozt brutalcrozt added the request label Aug 16, 2019
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Aug 16, 2019

You must use --download-archive for this.

@dstftw dstftw closed this Aug 16, 2019
@brutalcrozt
Copy link
Author

@brutalcrozt brutalcrozt commented Aug 16, 2019

do you think when using --yes-playlist also involving --download-archive is a bad suggestion?

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Aug 16, 2019

It's a very bad suggestion.

@brutalcrozt
Copy link
Author

@brutalcrozt brutalcrozt commented Aug 16, 2019

Then you owe me an explanation 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.