Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let youtube-dl handle the filename of video itself #22265

Closed
madobet opened this issue Aug 30, 2019 · 2 comments
Closed

Let youtube-dl handle the filename of video itself #22265

madobet opened this issue Aug 30, 2019 · 2 comments
Labels

Comments

@madobet
Copy link

@madobet madobet commented Aug 30, 2019

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2019.08.13
  • I've searched the bugtracker for similar feature requests including closed ones

Description

I've had the same issue with #20312

Would it be possible to let youtube-dl handle the filename and simply pass a temporary name (such as MD5 of the URL) to aria2c (or any other external downloader)?

The link of problem video: https://www.youtube.com/watch?v=O7eZXXzLrVE

@madobet madobet added the request label Aug 30, 2019
@madobet madobet changed the title Let youtube-dl handle the filename of downloaded video itself Let youtube-dl handle the filename of video itself Aug 30, 2019
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Aug 30, 2019

This will require storing temp name somewhere between runs in order to be able to support resume. But where to store it in order to be able to pick it up on the next run? You stumble the same problem you're trying to solve. I guess it's worth fixing actual bugs instead of introducing another duct tape mess in 3rdparty software.

@dstftw dstftw closed this Aug 30, 2019
@madobet
Copy link
Author

@madobet madobet commented Sep 1, 2019

This will require storing temp name somewhere between runs in order to be able to support resume. But where to store it in order to be able to pick it up on the next run? You stumble the same problem you're trying to solve. I guess it's worth fixing actual bugs instead of introducing another duct tape mess in 3rdparty software.

I also agree that aria2 should fix this bug, but what I mean is that we can not expect every similar bug in all possible external downloader, so reduce youtube-dl's dependence on an external downloader's function (filename processing rules) would be a possible choise.
There is no need for storing, using the same URL(filename etc.) and the same algorithm should get the same temporary name.
Of course, the best solution would be to Implement multi-threaded download function by ourselves. ;P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.