Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Checklist
Description
The difference between SOCKS5 and SOCKS5H is that SOCKS5H resolves DNS requests through the proxy and SOCKS5 resolves them locally. The DNS leak has technically been addressed in #9677 and it appears to been removed based on tests I carried out sniffing for DNS packets while running youtube-dl with
--proxy socks5://(this is the relevant line, I think).So
youtube-dl --proxy socks5://behaves howyoutube-dl --proxy socks5h://should behave, and the latter misbehaves:I suggest that youtube-dl should accept the
socks5hprotocol and use for it the implementation of SOCKS5 that already exists (where DNS is resolved by the SOCKS server).And maybe
socks5's implementation should be changed to resolve DNS locally to honour the specification. The only issue I can see with fixing the names of the protocols is any scripts withsocks5://in them will start leaking DNS requests.