Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
mtime not being set on audio files in certain cases #2299
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I used
to download videos from a playlist + extract mp3 audios from those videos.
While it was processing, I noted that one video errored for no particular reason. After everything was downloaded and converted, I decided to rerun the command, since youtube-dl claims to be able to skip already downloaded things. Already downloaded video files, in fact, weren't re-downloaded, but every single audio file was re-created. I guess there is nothing one can do, with a video you at least know its size from youtube, so you can easily check if it's already downloaded or not, but you don't know how big an extracted audio file would be, so you don't know if the audio file you have is a complete audio file or not, so to be safe it just re-converts every single audio file. This is a little annoying, try to re-encode 10gb of audio, but I don't think that this is a bug, it looks rather intentional, like a feature.
The actual issue here is that Last-Modified time of re-done audio files is set to now instead of the time of corresponding youtube video. That is a bug. youtube-dl sets Last-Modified correctly the first time you run the command, but then forgets to set it when the command is ran again and audio files are re-created.
I'm sorry if that was already reported, there are a lot of issues open here.
Steps to reproduce
Run
Repeat 1
What I see
What I expected to see