Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nbc] All network support #23049

Closed
StevenDTX opened this issue Nov 11, 2019 · 8 comments
Closed

[nbc] All network support #23049

StevenDTX opened this issue Nov 11, 2019 · 8 comments

Comments

@StevenDTX
Copy link

@StevenDTX StevenDTX commented Nov 11, 2019

Checklist

  • I'm reporting a site feature request
  • I've verified that I'm running youtube-dl version 2019.11.05
  • I've searched the bugtracker for similar site feature requests including closed ones

Description

NBC.com now streams all of their networks (Bravo, E!, CNBC, Oxygen, etc). It would be awesome if the NBC extractor could download all of these networks/shows.

There is another similar Issue posted, but it was closed with "Account required". There are currently some free URLs that could be tested against:

https://www.nbc.com/e-live-from-the-red-carpet/video/e-peoples-choice-awards-red-carpet/4064509

https://www.nbc.com/back-in-the-game/video/evander-holyfield-featuring-marcus-lemonis/4060395

https://www.nbc.com/the-real-housewives-of-new-jersey/video/sex-lies-and-video-debates/4059276

C:\>c:\support\youtube-dl.exe https://www.nbc.com/e-live-from-the-red-carpet/video/e-peoples-choice-awards-red-carpet/4064509 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.nbc.com/e-live-from-the-red-carpet/video/e-peoples-choice-awards-red-carpet/4064509', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.11.05
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg N-95216-ge6625ca41f
[debug] Proxy map: {}
[NBC] 4064509: Downloading JSON metadata
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\__init__.py", line 474, in main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\__init__.py", line 464, in _real_main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\YoutubeDL.py", line 2018, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\nbc.py", line 116, in _real_extract
TypeError: 'NoneType' object is not subscriptable

Thanks!

@sufr3ak
Copy link

@sufr3ak sufr3ak commented Nov 11, 2019

I wanted to add support for this. I keep getting errors with NBC.

@tony-izzo
Copy link

@tony-izzo tony-izzo commented Dec 12, 2019

I'm getting the same error with all content from E! network. Example:

https://www.nbc.com/keeping-up-with-the-kardashians/video/hard-candy/4063177

@roadzy
Copy link

@roadzy roadzy commented Jan 16, 2020

I can provide an account to test with.

@StevenDTX
Copy link
Author

@StevenDTX StevenDTX commented Jan 21, 2020

Thanks a lot @remitamine. This works great!

You can probably close out all the site requests for Oxygen, CNBC and E! now, and redirect folks to this extractor.

@roadzy
Copy link

@roadzy roadzy commented Jan 21, 2020

I tried a video from oxygen and it failed. Do you want me to post the error message or open a new ticket?

@StevenDTX
Copy link
Author

@StevenDTX StevenDTX commented Jan 21, 2020

I tried a video from oxygen and it failed. Do you want me to post the error message or open a new ticket?

Are you using a link like https://www.oxygen.com/dateline-secrets-uncovered/season-8/the-threat or https://www.nbc.com/dateline-secrets-uncovered/video/the-threat/4099435 ?

You must use the nbc.com link from: https://www.nbc.com/networks/oxygen

Also, did you build a new version of youtube-dl? The latest version does not include the updated NBC extractor.

@roadzy
Copy link

@roadzy roadzy commented Jan 21, 2020

I did the nbc.com url. I assumed this was in the newest update. I’ll apply the patch manually and try again. Thnx.

@roadzy
Copy link

@roadzy roadzy commented Jan 22, 2020

Recreated the nbc file again and it seems to be working this time. No clue... oh well thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.