Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Prefer WebM when available #231
Comments
|
You need to review it anyway so here is just a patch:
|
|
We already tried that and did prefer webm for a time (to be precise, from 2011.09.06 to 2011.09.18b). Users immediately complained (see #165 and #168). You can prefer webm with I think we should have a configuration file so that everyone can set his or her preference (and debian would probably serve it with webm preference). However, you can easily configure a shell alias or install a wrapper script to the same effect. |
|
I do not see it patched in Debian unstable. |
|
Any idea on how this could be solved without having to patch youtube-dl downstream? Does Fedora allow to install a default configuration (maintained by the package maintainer) into |
|
I do not see any existing Fedora patches downstream for some custom configurations: http://pkgs.fedoraproject.org/gitweb/?p=youtube-dl.git;a=tree;h=refs/heads/master;hb=master |
|
Sure, downstream maintainers are certainly free to maintain patches. However, that only complicates their life, and I personally do prefer WebM as well, so why not make life easy for everyone? I'd love to have Till Maas or @rbrito chip in. Could you ship a configuration file
? If not, is there any other way upstream can make your life easier? |
|
Sure an upstream implementation of both a config file read-in and some generic Free-formats preferring option would be ... preferred. Distro can then just ship a distro-specific config file, without maintenance of a code patch, thanks. |
|
@jankratochvil, I use to patch youtube-dl in the packages that I provide to Debian, but having to patch it all the time that I uploaded something new was killing me (I already orphaned some packages in Debian that I used to maintain, but I'm not really giving up on youtube-dl, especially because I use it way too frequently), and I am really short on time these few weeks. Things will become saner for me starting with the 15th of December and I will have free time during the holidays to hack on things, have fun playing with experimental stuff... For instance, I hope to integrate the ability to grab subtitles in the free time that I will have. If possible, implement the selection of quality of videos for other information extractors and generalize that in all the classes... The idea of @phihag of having a configuration file like OK, so this was much longer than you probably expected, but I'm also giving you some details of the next steps... :) |
|
@rbrito Configuration files |
|
How about using $XDG_CONFIG_HOME/youtube-dl.conf (or $HOME/.conf/youtube-dl.conf) by default for the per user config file to follow current standard processes. |
|
Reopening until we have |
|
Possible solution could be to add option similar to '--formats', i.e. '--video-formats webm/mp4/flv', though naming of options becomes a bit confusing. |
|
Hi there. 2011/11/30 Vladimir Berezhnoy
Why not make Regards. Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA |
|
After a comment from rbrito I wonder if there is any sense in adding one more option, while the same behaviour can be achieved by using |
|
On Dec 01 2011, Vladimir Berezhnoy wrote:
Agreed. If this is going to a configuration file, anyway, we can simply put Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA |
|
The problem is after YouTube adds new dimensions/extensions=formats such extra free-preferring configuration file (such as my current alias in ~/.bashrc) will become stale. The new dimensions/extensions will get disabled by using such configuration file. --prefer-free-formats would still stay working. |
|
jankratochvil> --prefer-free-formats would still stay working. A better option would be to add alias '--format webm/mp4/flv' |
|
The new format to youtube-dl gets added by upstream. The new format will not be noticed by distro maintainers who just rebase to a new upstream release but the distro still would have --format 45/44/43/(...) in their distro config. |
|
Just for the record, I'm not disagreeing here with anybody. On Dec 04 2011, Jan Kratochvil wrote:
Geee... Besides contributing some parts to youtube-dl, I'm a distro I'm not rebasing anything on anything, as that was too much work, especially From a distro point-of-view, the best is to just ship an unmodified I already have divergence on my own tree, where I maintain a branch called Regards, Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA |
|
FYI found now that: Sure it may be just some server-side problem but preferring WebM apparently breaks the functionality in this case. |
|
@jankratochvil That's just a server-side issue which has been cleaned up by now. This happens from time to time with mp4 as well. |
$subj says it all.
WebM is high quality Free codec with widely available decoding support so when the same resolution is available in multiple formats incl. WebM choose WebM.