Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dailymotion broken #23256

Closed
christopherosko opened this issue Nov 28, 2019 · 4 comments
Closed

Dailymotion broken #23256

christopherosko opened this issue Nov 28, 2019 · 4 comments

Comments

@christopherosko
Copy link

@christopherosko christopherosko commented Nov 28, 2019

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2019.11.28
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.dailymotion.com/video/x7ohvao', u'-F']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.11.28
[debug] Python version 2.7.12 (CPython) - Linux-4.4.0-71-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: ffmpeg git-2014-12-04-43f56cd-static
[debug] Proxy map: {}
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/bin/youtube-dl/__main__.py", line 19, in <module>
  File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 474, in main
  File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 464, in _real_main
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2018, in download
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 796, in extract_info
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/dailymotion.py", line 235, in _real_extract
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/dailymotion.py", line 50, in _call_api
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/dailymotion.py", line 31, in _get_dailymotion_cookies
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 2831, in _get_cookies
  File "/usr/lib/python2.7/Cookie.py", line 583, in __init__
    if input: self.load(input)
  File "/usr/lib/python2.7/Cookie.py", line 643, in load
    for k, v in rawdata.items():
AttributeError: 'unicode' object has no attribute 'items'

Description

Since the last update I get a python error with dailymotion fetcher.

@christopherosko
Copy link
Author

@christopherosko christopherosko commented Nov 29, 2019

Hi @remitamine ,
From which issue is this the duplicate ? I can't find it. Thanks

@dstftw dstftw reopened this Nov 29, 2019
@dstftw dstftw removed the duplicate label Nov 29, 2019
@remitamine
Copy link
Collaborator

@remitamine remitamine commented Nov 29, 2019

Duplicate of #20673, it's the same problem.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Nov 29, 2019

It's more about severity than duplication - previously working extractor is now completely broken under python 2.

@remitamine
Copy link
Collaborator

@remitamine remitamine commented Nov 29, 2019

#20673 closed as the problem no longer applies to twitter extractor, however, the problem still affects all extractors calling _get_cookies method.

@ytdl-org ytdl-org deleted a comment from afsharsafavi Dec 3, 2019
@ytdl-org ytdl-org locked and limited conversation to collaborators Dec 3, 2019
@dstftw dstftw closed this in 6c22cee May 4, 2020
bbepis referenced this issue in animelover1984/youtube-dl May 14, 2020
…s #23256, closes #24776)

To always ensure cookie name and value are bytestrings on python 2.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.