Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mutagen for embedding thumbnails #23368

Closed
tripulse opened this issue Dec 10, 2019 · 2 comments
Closed

Use mutagen for embedding thumbnails #23368

tripulse opened this issue Dec 10, 2019 · 2 comments
Labels

Comments

@tripulse
Copy link

@tripulse tripulse commented Dec 10, 2019

Checklist

  • I'm asking a question
  • I've looked through the README and FAQ for similar questions
  • I've searched the bugtracker for similar questions including closed ones

Question

youtube-dl uses external binaries to embed thumbnails into MP4/MP3 files. My question is that why use FFmpeg or AtomicParsley for embedding thumbnails.

Because, there is a library named mutagen which can handle ID3 tags and MP4 metadata atoms.
And does in-place manipulation without generating a temporary file. And, the biggest perk is that it is made in native Python.

Then what is the point of using AtomicParsley for the sole purpose of embedding thumbnails into a MP4 (MPEG-4 Part-II) file?

@tripulse tripulse added the question label Dec 10, 2019
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Dec 10, 2019

  1. Because this is what implemented.
  2. Inplace manipulation is a very bad idea.
@dstftw dstftw closed this Dec 10, 2019
@tripulse
Copy link
Author

@tripulse tripulse commented Dec 21, 2019

Explain, why inplace manipulation is a very bad idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.