Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Cross-platform duplicates (extension duplicates) #23502
Comments
|
|
This does not solve the issue because there is no archive file in the above scenario. Shouldn't it be the default behavior be to avoid duplicates?? If a video is present within the output directory, shouldn't it be assumed that it would be present in the archive? |
|
no:
so, either download with the same environment(same executables(ex: ffmpeg) and dependencies(ex: pycrypto) present and the same configuration) or use a download archive. |
|
|
Hindsight is always 20/20. I believe avoiding duplicates should be the default, and allowing extension duplicates should be a cli argument, but that's just me. Although I don't quite agree, I appreciate the feedback and the awesome software! |
Verbose log
No errors or warning generated
Description
Duplicates are generated when a drive is shared between OS's, e.g. Windows & Linux.
This is due to the fact that the video files are saved in different formats (e.g.
.mkvand.mp4)For example, if a batch file is executed on Linux, and then resumed on Windows, each file will be duplicated (once with mkv and once with mp4). This results in duplicated videos and wasted download time.
Example
A batch file contains many links:
The batch file is downloaded on Linux, resulting in the file:
5 Simple RV Hacks-z7aXex18_wg.mkvNow the batch file is resumed on Windows. You'd expect to see '... has already been downloaded', but instead you get the following file
5 Simple RV Hacks-z7aXex18_wg.mp4Now you have duplicate files and the files that had already been downloaded on Linux are downloaded again
Expected Behavior
Files should not be duplicated, regardless of extension
Proposed Fix
Before downloading a video, check if that video exists in directory with any extension