Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--update flag does not resolve symbolic links when writing to disk #23991

Closed
VADemon opened this issue Feb 8, 2020 · 0 comments
Closed

--update flag does not resolve symbolic links when writing to disk #23991

VADemon opened this issue Feb 8, 2020 · 0 comments

Comments

@VADemon
Copy link

@VADemon VADemon commented Feb 8, 2020

Checklist:

  • I'm reporting a broken site support issue
  • I've verified that I'm running youtube-dl version 2020.01.24
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
    ↑ Not applicable
  • I've searched the bugtracker for similar bug reports including closed ones
  • I've read bugs section in FAQ

(Using 1 version behind for testing purposes)

Verbose log

Z:\>youtube-dl.exe --version
2020.01.15

Z:\symlink-test>mklink ydl.exe youtube-dl.exe
symbolic link created for ydl.exe <<===>> youtube-dl.exe

Z:\symlink-test>ydl -U --verbose
[debug] System config: []
[debug] User config: ['--limit-rate', '10M', '-f']
[debug] Custom config: []
[debug] Command-line args: ['-U', '--verbose']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2020.01.15
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
Updating to version 2020.01.24 ...
Waiting for file handle to be closed ...

Z:\symlink-test>Updated youtube-dl to version 2020.01.24.
Z:\symlink-test>ydl --version
2020.01.24

Z:\symlink-test>youtube-dl.exe --version
2020.01.15

Description

Using the -U flag does not resolve symbolic links for the executable on Windows.

Expected: youtube-dl resolves the symbolic link and writes to the final destination.

Reproducable on Windows cmd and within Cygwin:

  1. Download youtube-dl.exe and create a symlink by the name "ydl.exe"
  2. Using the symbolic link, update: ydl -U
  3. Result: ydl.exe is now a file and the most recent version; youtube-dl.exe remained an old version.
dstftw added a commit that referenced this issue Feb 8, 2020
@dstftw dstftw closed this in ddc8cea Feb 8, 2020
dstftw added a commit that referenced this issue Feb 8, 2020
bbepis referenced this issue in animelover1984/youtube-dl Feb 27, 2020
bbepis referenced this issue in animelover1984/youtube-dl Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.