Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube-dl update : python version compaptibility #2417

Closed
octarin opened this issue Feb 20, 2014 · 8 comments
Closed

Youtube-dl update : python version compaptibility #2417

octarin opened this issue Feb 20, 2014 · 8 comments

Comments

@octarin
Copy link

@octarin octarin commented Feb 20, 2014

Ok, so i make an update to this issue #556, which was the suggestion i first came with.

It no longer works with python3.
When updating, i get an error about some ssl certs ( sadly, i have just updated using python2 (by modifying the symlink, i'll show you how), so to reproduce the bug, i must wait the new update. However, if someone could do it... I'm using python3.3 on archlinux).

To make the update, i had to do:
# rm /usr/bin/python && ln -s /usr/bin/python2 /usr/bin/python
It's very unconvenient.

So, like the precedent thread threating about this kind of error, i suggest to use explicitly python2 ( #/usr/bin/env python2), or the same with python2.7, assuming that it does'nt work either with python2.6.

This change could be done waiting the python3.3 support, or be permanent if it can't be done.

Thank you.

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Feb 20, 2014

As far as I know 3.3 is supported so this is simply a bug.

It would really help to have the Traceback, can you rollback the change and try to reproduce it please?

@octarin
Copy link
Author

@octarin octarin commented Feb 20, 2014

Here's the output:

Updating to version 2014.02.20 ...
Traceback (most recent call last):
File "/usr/lib/python3.3/runpy.py", line 160, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python3.3/runpy.py", line 73, in _run_code
exec(code, run_globals)
File "/usr/local/bin/youtube-dl/main.py", line 18, in
File "/usr/local/bin/youtube-dl/youtube_dl/init.py", line 800, in main
File "/usr/local/bin/youtube-dl/youtube_dl/init.py", line 777, in _real_main
File "/usr/local/bin/youtube-dl/youtube_dl/update.py", line 160, in update_self
File "/usr/lib/python3.3/urllib/request.py", line 156, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python3.3/urllib/request.py", line 469, in open
response = self._open(req, data)
File "/usr/lib/python3.3/urllib/request.py", line 487, in _open
'_open', req)
File "/usr/lib/python3.3/urllib/request.py", line 447, in _call_chain
result = func(_args)
File "/usr/lib/python3.3/urllib/request.py", line 1289, in https_open
context=self._context, check_hostname=self._check_hostname)
File "/usr/lib/python3.3/urllib/request.py", line 1248, in do_open
h.request(req.get_method(), req.selector, req.data, headers)
File "/usr/lib/python3.3/http/client.py", line 1065, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python3.3/http/client.py", line 1103, in _send_request
self.endheaders(body)
File "/usr/lib/python3.3/http/client.py", line 1061, in endheaders
self._send_output(message_body)
File "/usr/lib/python3.3/http/client.py", line 906, in send_output
self.send(msg)
File "/usr/lib/python3.3/http/client.py", line 844, in send
self.connect()
File "/usr/lib/python3.3/http/client.py", line 1209, in connect
ssl.match_hostname(self.sock.getpeercert(), self.host)
File "/usr/lib/python3.3/ssl.py", line 213, in match_hostname
% (hostname, ', '.join(map(repr, dnsnames))))
ssl.CertificateError: hostname 'yt-dl.org' doesn't match either of 'aries.uberspace.de', 'uberspace.de', '
.aries.uberspace.de'

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Feb 20, 2014

Thank you very much!

It seems it might be an issue on your side, can you please navigate in your
browser to

https://yt-dl.org

And tell me what you see (error, warnings, redirects)

Filippo Valsorda

@octarin
Copy link
Author

@octarin octarin commented Feb 20, 2014

I navigated to yt-dl.org, and the https works fine, I haven't any warning message about the https cert.

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Feb 20, 2014

This is really odd. Has "Uberspace" anything to do with how you connect to
Internet?

Ah, I strongly suggest to leave the symlink as you found it, otherwise a
lot of things might/will break in your system.

On Thursday, February 20, 2014, octarin notifications@github.com wrote:

I navigated to yt-dl.org, and the https works fine, I haven't any warning
message about the https cert.

Reply to this email directly or view it on GitHubhttps://github.com//issues/2417#issuecomment-35643390
.

Filippo Valsorda

@octarin
Copy link
Author

@octarin octarin commented Feb 20, 2014

Yes, that's why i said it was embarassing ^^.

And for uberspace.de, I don't think so, because i've tried twice from different places and it remains the same problem (I live in France).

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Feb 20, 2014

Umh. @phihag has uberspace.de something to do with the hosting, then?

@phihag
Copy link
Contributor

@phihag phihag commented Feb 20, 2014

uberspace is indeed our hosting provider. https://yt-dl.org requires SNI. I'll look into what we can do on the hosting part, and why Python 3 doesn't support SNI.

@dstftw dstftw closed this May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.