Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix youtube-dl embedded options & update forbidden 403 pinned issue #24891

Closed
elibroftw opened this issue Apr 20, 2020 · 3 comments
Closed

Fix youtube-dl embedded options & update forbidden 403 pinned issue #24891

elibroftw opened this issue Apr 20, 2020 · 3 comments
Labels

Comments

@elibroftw
Copy link

@elibroftw elibroftw commented Apr 20, 2020

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2020.03.24
  • I've searched the bugtracker for similar feature requests including closed ones

Description

I use the embedded version of Youtube-dl and I find its options somewhat different and vague compared to command-line options. I recently had the 403 forbidden error and the solution says to use --rm-cache-dir but what is the corresponding embedded way? It took some time to figure it out: the "rm-cache-dir" has the alternative solution of "cachedir: False" but the language used in the options description says "False to disable filesystem cache." I don't know about you but the meaning of remove and disable is not the same. You should really update that post to include the embedded way of fixing the problem, it would've saved me a lot of time. It would also be beneficial to not lock the pinned post so that people don't create a new issue. That's just one problem (dual meanings/descriptions).

Also this takes up 3 lines instead of 2.

What I would really appreciate is a) if each of these options descriptions specified the type of the option. E.g. keepvideo (bool): Keep the video file after post-processing. A developer should not have to make assumptions or infer what the type will be. It's not a thinking heavy task so I'd appreciate it. Secondly, you should also include the command line alternative in the description so a developer knows the corresponding command-line option.

@elibroftw elibroftw added the request label Apr 20, 2020
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 20, 2020

You don't need to include this in embedded code in the first place. Running it once from CLI is enough.

@dstftw dstftw closed this Apr 20, 2020
@elibroftw
Copy link
Author

@elibroftw elibroftw commented Apr 20, 2020

What do you mean by "You don't need to include this in embedded code in the first place. Running it once from CLI is enough"? I swear you didn't even read what I said.
I use the embedded version youtube-dl and I included it because I shouldn't have to spend that much time to fix the issue. At least fix the options' descriptions instead of closing the issue and giving a vague answer that I don't even understand.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 20, 2020

Again: do not use cachedir: False, this is not an alternative solution as this disables caching completely with corresponding consequences. And again: running --rm-cache-dir once from CLI is enough to get this fixed.

@ytdl-org ytdl-org locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.