Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Description Flag #25378

Closed
jugendhacker opened this issue May 23, 2020 · 9 comments
Closed

Audio Description Flag #25378

jugendhacker opened this issue May 23, 2020 · 9 comments
Labels

Comments

@jugendhacker
Copy link

@jugendhacker jugendhacker commented May 23, 2020

Checklist

  • I'm asking a question
  • I've looked through the README and FAQ for similar questions
  • I've searched the bugtracker for similar questions including closed ones

Question

I'm currently looking into how #24098 could be fixed an found a way to determinate if a audio track has audio description or not. Now I'm wondering if there is a flag or so that could be set in the extractor to tell if this track has a audio description or not? So youtube-dl could let the user select it or not without this workaround via the Format option (as described in the related issue)

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 23, 2020

No such flag.

@dstftw dstftw closed this May 23, 2020
@jugendhacker
Copy link
Author

@jugendhacker jugendhacker commented May 23, 2020

@dstftw but wouldn't it be a good idea to add one then?

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 23, 2020

Only generic meta fields can be added.

@jugendhacker
Copy link
Author

@jugendhacker jugendhacker commented May 23, 2020

Only generic meta fields can be added.

@dstftw I don't understand what you want to say, sorry.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 23, 2020

I won't add another meta field just for a single extractor. All meta fields added must be carefully designed and proven to be usable across multiple extractors.

@jugendhacker
Copy link
Author

@jugendhacker jugendhacker commented May 23, 2020

I don't think ZDF is the only Service where you can download with and without audio description.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 23, 2020

Also I don't see much difference whether it's selected based on format_id on some fancy flag. In both cases this involves format selection expression.

@jugendhacker
Copy link
Author

@jugendhacker jugendhacker commented May 23, 2020

The problem is currently you have to manually find the best video/audio format without AD, but you don't even know what format has AD and what does not, because it doesn't tell you. So you have to try it manually several times until you find the right one. Now you have to manually set it. Maybe, if you do bulk downloads, the next video doesn't have this specific format so you start again finding the right format manually.

Now I'm thinking about a --enable-ad (or --diable-ad) CLI flag so youtube-dl could select the best format for you with your AD preference.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 23, 2020

Wrong. format_id contains Audiodeskription that can easily be excluded with format selection expression.
As already pointed out I won't introduce new options just because of single extractor especially when it's covered by existing functionality.

@ytdl-org ytdl-org locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.