Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giant Bomb premium support #25421

Open
JordanWeatherby opened this issue May 26, 2020 · 1 comment
Open

Giant Bomb premium support #25421

JordanWeatherby opened this issue May 26, 2020 · 1 comment

Comments

@JordanWeatherby
Copy link
Contributor

@JordanWeatherby JordanWeatherby commented May 26, 2020

Checklist

  • I'm reporting a site feature request
  • I've verified that I'm running youtube-dl version 2020.05.08
  • I've searched the bugtracker for similar site feature requests including closed ones

Description

Giant Bomb has premium videos on its service. These are currently not supported by the giantbomb extractor.

I considered trying to add this functionality myself but as someone who is relatively new to the codebase I wasn't sure how best to go about this.

The login code I have seen for other extractors I'm not sure would work on Giant Bomb as they use captcha on login.

Giant Bomb has a great API ( https://www.giantbomb.com/api/documentation ) which could be used for this but I believe they only support logging in via API keys rather than the standard username and password which youtube-dl uses.

Or is it possible this could be done using cookies?

If anyone could give me some pointers towards some extractors to look at for hints (or want to pick this up themselves) it would be greatly appreciated.

@JordanWeatherby
Copy link
Contributor Author

@JordanWeatherby JordanWeatherby commented Sep 24, 2020

I discovered just using --cookies allows these to download fine.

I'm going to leave this open as I'd prefer a more elegant login/api solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.