Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funimation Subtitles #25645

Open
joshbrown50 opened this issue Jun 12, 2020 · 4 comments
Open

Funimation Subtitles #25645

joshbrown50 opened this issue Jun 12, 2020 · 4 comments
Labels

Comments

@joshbrown50
Copy link

@joshbrown50 joshbrown50 commented Jun 12, 2020

Checklist

  • [ x] I'm asking a question
  • [ x] I've looked through the README and FAQ for similar questions
  • [ x] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE

I know there is a pull request to update the funimation extractor to allow it to download the subtitles, but It's been almost 2 months now with no progress. I find it very tedious to manually download the vtt file every time especially when compared to the ease of use of downloading crunchyroll videos with subtitles.

How long will it take for the pull request to be merged if it does end up being merged?
And if it's not merged, how to I download that branch so I can stop having to manually download the subtitles?

@cancerousname69
Copy link

@cancerousname69 cancerousname69 commented Jun 19, 2020

--embed-subs

Should work.

@joshbrown50
Copy link
Author

@joshbrown50 joshbrown50 commented Jun 19, 2020

--embed-subs

Should work.

I tried this and it said there were no subtitle files to embed

@frozenpandaman
Copy link

@frozenpandaman frozenpandaman commented Jun 26, 2020

why not use nyaa lol

@Mevious
Copy link

@Mevious Mevious commented Jul 8, 2020

How long will it take for the pull request to be merged if it does end up being merged?

#24906 is my first pull request so I don't have a good idea. Considering how many open pull requests there are, I don't expect it getting merged any time soon if ever.

And if it's not merged, how to I download that branch so I can stop having to manually download the subtitles?

You can git clone my fork or simply download the code from that page and run youtube-dl from the source folder.
E.g., python "C:\path_to_downloaded_code\youtube-dl\youtube_dl\__main__.py"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.