Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to generate an info.json file with identifying data scrubbed #25681

Closed
hunter0002 opened this issue Jun 15, 2020 · 3 comments
Closed

Comments

@hunter0002
Copy link

@hunter0002 hunter0002 commented Jun 15, 2020

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2020.06.16
  • I've searched the bugtracker for similar feature requests including closed ones

Description

The --write-info-json flag has the potential to include identifying data in the generated info.json file. This includes (but is potentially not limited to):

  • Depending on other flags, e.g. those used by the default configuration of tubeup, the _filename field may contain the full path name rather than the file name, which may allow the user's home directory name and OS to be inferred (this does not happen by default)
  • In most (but not all) googlevideo.com URLs, the user's IP address is included as part of the URL

It should preferably be possible to generate a JSON file with identifying data scrubbed from the file.

This is related to (but not exactly the same issue as) #25576. This is mainly because the IP address leakage issue was not identified initially.

@hunter0002 hunter0002 added the request label Jun 15, 2020
@hunter0002 hunter0002 changed the title Allow the user to generate an info.json file with identifying data scrubbed. Allow the user to generate an info.json file with identifying data scrubbed Jun 15, 2020
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Jun 15, 2020

Again:

  1. _filename does not contain any path only filename according to provided output template.
  2. URLs are generated by Youtube. If you modify them in any way downloading will no longer work.
@garoto
Copy link

@garoto garoto commented Jun 15, 2020

How can it be youtube-dl's job to redact personal information like IP addresses from the generated json output? This makes no sense.

@hunter0002
Copy link
Author

@hunter0002 hunter0002 commented Jun 15, 2020

It was implied by another tubeup user that it would be better for youtube-dl to do it to avoid deliberately modifying files uploaded to the Internet Archive. I don't entirely understand this reasoning either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.