ZSH completion not currently included in PyPI releases

[AndydeCleyre]

Checklist

• I'm reporting a broken site support issue
• I've verified that I'm running youtube-dl version 2020.06.16.1
• I've checked that all provided URLs are alive and playable in a browser
• I've checked that all URLs and arguments with special characters are properly quoted or escaped
• I've searched the bugtracker for similar bug reports including closed ones
• I've read bugs section in FAQ

Verbose log

This is not relevant, but I'm including it to ensure satisfaction of the general bug reporting guidelines:

$ youtube-dl -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2020.06.16.1
[debug] Python version 3.8.3 (CPython) - Linux-5.7.4-zen1-1-zen-x86_64-with-glibc2.2.5
[debug] exe versions: ffmpeg 4.2.3, ffprobe 4.2.3, rtmpdump 2.4
[debug] Proxy map: {}
Usage: youtube-dl [OPTIONS] URL [URL...]

youtube-dl: error: You must provide at least one URL.
Type youtube-dl --help to see a list of all options.

Description

Folks who install from source, or via built packages for their distro, are able to enjoy the ZSH completions you provide.

While those who install via PyPI are able to access the fish and bash completions, so that they can copy/link/add them to their shell manually, they are not provided with the ZSH completions with which to do the same. Neither are they provided with the Makefile+template with which to generate these completions.

I'm requesting that the generated ZSH completions be included in the PyPI build (as the generated completion doesn't seem to be platform independent or anything).

The exact location of the file does not matter to me personally, as I'm installing as a user and within a venv, but FWIW on Arch Linux the default $fpath includes /usr/share/zsh/site-functions.

The change would affect at least three files:

Makefile, which currently includes:

pypi-files: youtube-dl.bash-completion README.txt youtube-dl.1 youtube-dl.fish

setup.py, which currently includes:

    files_spec = [
        ('etc/bash_completion.d', ['youtube-dl.bash-completion']),
        ('etc/fish/completions', ['youtube-dl.fish']),
        ('share/doc/youtube_dl', ['README.txt']),
        ('share/man/man1', ['youtube-dl.1'])
    ]

And MANIFEST.in.

[AndydeCleyre]

I searched for zsh pypi -- which issue is this a duplicate of?

[AndydeCleyre]

Ah, found it. Linking here: #9231