Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All formats downloading slightly broken #25867

Closed
zhenyahacker opened this issue Jul 1, 2020 · 1 comment
Closed

All formats downloading slightly broken #25867

zhenyahacker opened this issue Jul 1, 2020 · 1 comment
Labels

Comments

@zhenyahacker
Copy link

@zhenyahacker zhenyahacker commented Jul 1, 2020

Seems like downloading of all available formats is slightly broken due to inappropriate for very this usage output files naming.
What I mean:

youtube-dl ragWo0bX9Pc --all-formats --get-filename
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.m4a
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.webm
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4
FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4

As you can see, there is a bunch of exactly same filenames to be generated, and thus only first variant from list is really being downloaded, others are just skipped because "[download] FOUR YEARS OF MARIO MAKER-ragWo0bX9Pc.mp4 has already been downloaded".

I think it would make sense to change filename generation to add a variant/quality name to it, maybe not for any usage but for all formats execution.

@dstftw dstftw closed this Jul 1, 2020
@dstftw dstftw added the duplicate label Jul 1, 2020
@zhenyahacker
Copy link
Author

@zhenyahacker zhenyahacker commented Jul 1, 2020

@dstftw Технически - повтор, но предложенное 7 лет назад решение в данный момент не работает.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.