Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant postprocessor for "--extract-audio" #2607

Closed
epitron opened this issue Mar 23, 2014 · 6 comments
Closed

Redundant postprocessor for "--extract-audio" #2607

epitron opened this issue Mar 23, 2014 · 6 comments

Comments

@epitron
Copy link
Contributor

@epitron epitron commented Mar 23, 2014

It looks like the postprocessor isn't needed anymore when you use --extract-audio on a youtube url:

$ youtube-dl --extract-audio https://www.youtube.com/watch?v=vWD7k6TrJ-g
[youtube] Setting language
[youtube] vWD7k6TrJ-g: Downloading webpage
[youtube] vWD7k6TrJ-g: Downloading video info webpage
[youtube] vWD7k6TrJ-g: Extracting video information
[download] Destination: Chromatics - Tick Of The Clock.m4a
[download] 100% of 4.37MiB in 00:01
[youtube] Post-process file Chromatics - Tick Of The Clock.m4a exists, skipping

It saved it directly to an m4a audio file, but still tried to run the audio extraction postprocessor.

Maybe a simple solution is to have the postprocessor ignore audio files (m4a, mp3, etc.)?

@epitron epitron changed the title --extract-audio tries to overwrite file... Redundant postprocessor for "--extract-audio" Mar 23, 2014
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Mar 23, 2014

You may want to convert it to another format using --audio-format.

@tewe
Copy link

@tewe tewe commented Aug 25, 2014

Asking YT for M4A always results in broken files for me, so I want an option to force downlading of the MP4 and post-process to M4A locally.

@phihag
Copy link
Contributor

@phihag phihag commented Aug 25, 2014

@tewe Can you tell me where you did look for existing options that do that? -x --audio-format m4a -f mp4 should do what you want. However, it may be more beneficial to download the m4a file and reencode it, as suggested here.

@tewe
Copy link

@tewe tewe commented Aug 25, 2014

Thank you. I did not cross my mind that when a post-processing option doesn't do any post-processing I might turn to completely unrelated options to fix that.

@sunk818
Copy link

@sunk818 sunk818 commented Nov 7, 2014

@tewe > M4A always results in broken files for me

Winamp technical support said their player does not support MPEG DASH. This is what I use to convert m4a DASH audio to m4a AAC LC without losing quality.
ffmpeg -i input.m4a -vn -c:a copy output.m4a

@phihag > -x --audio-format m4a -f mp4

Will this parameter download the entire mp4 then extract the audio out of it? Are downloading more data we need then discard the video portion? If that is true, seems like we are wasting bandwidth unnecessarily?

phihag added a commit that referenced this issue Jan 23, 2015
@phihag
Copy link
Contributor

@phihag phihag commented Jan 23, 2015

youtube-dl 2015.01.23.4 and newer will automatically correct the header of the m4a file if ffmpeg is present on the system. I am therefore closing this issue. See our FAQ if you need help updating. Thank you for the report!

@phihag phihag closed this Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.