Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl no longer recognises twitch usernames #26158

Closed
ninjachicken1 opened this issue Jul 29, 2020 · 1 comment
Closed

youtube-dl no longer recognises twitch usernames #26158

ninjachicken1 opened this issue Jul 29, 2020 · 1 comment
Labels

Comments

@ninjachicken1
Copy link

@ninjachicken1 ninjachicken1 commented Jul 29, 2020

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2020.07.28
  • I've checked that all provided URLs are alive and playable in a browser - channel names and ids have been replaced with placeholders for examples sake.
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

As of the beginning of June, youtube-dl no longer recognises twitch channel names when processing a list of urls in a separate text file, and instead now requires the user to use the ids instead. When running youtube-dl, I use this command:
youtube-dl --download-archive downloaded.txt -i -o "%(uploader)s/%(upload_date)s - %(title)s - (%(duration)ss) [%(resolution)s].%(ext)s" --batch-file=channel_list.txt --dateafter 20190127

channel_list.txt looks something like this:
https://www.twitch.tv/channelname1/videos/all
https://www.twitch.tv/channelname2/videos/all
https://www.twitch.tv/channelname3/videos/all

This now results in the following error for each channel:
ERROR: twitch:videos:all returned error: Bad Request - Channel identifier "channelname1" is in an invalid format

Removing "videos/all" from the end gives a more useful error. So if the url looks like this:
https://www.twitch.tv/channelname1

Then the error I get looks like this:

[twitch:stream] channelname1: Downloading access token JSON
[twitch:stream] 12345678: Downloading stream JSON
ERROR: 12345678 is offline

So now we've shown that youtube-dl can get the channel id from the channel name. From this I can get an url that works, and it looks like this:
https://www.twitch.tv/12345678/videos/all

So while the issue is solved for me from an engineering standpoint, I still have the following problems:

  1. It took me two months to find this information - during that time a lot of the videos I wanted to download have probably expired. Plus, this info was not easy to find.
  2. Typing the ids in is more prone to human error than just copy/pasting the twitch urls like I used to.
  3. It's a lot of unnecessary busywork.
@dstftw dstftw closed this Jul 29, 2020
@dstftw dstftw added the incomplete label Jul 29, 2020
@ahmedtds
Copy link

@ahmedtds ahmedtds commented Jul 29, 2020

This pull request fixes it: #25606
There are instructions on comments on how to apply it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.