Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow conditional embedding of subtitles #26504

Closed
HalosGhost opened this issue Sep 2, 2020 · 2 comments
Closed

Allow conditional embedding of subtitles #26504

HalosGhost opened this issue Sep 2, 2020 · 2 comments
Labels

Comments

@HalosGhost
Copy link

@HalosGhost HalosGhost commented Sep 2, 2020

Checklist

  • I'm reporting a feature request
  • I've verified that I'm running youtube-dl version 2020.07.28
  • I've searched the bugtracker for similar feature requests including closed ones

Description

I have setup my configuration so that youtube-dl very helpfully downloads videos with all my preferred default options. However, one thing I would love to do is add --embed-subs to that configuration. I cannot though because, if videos do not have subtitles, then it will fail during post-processing.

So, I can imagine three solutions to this:

  • change --embed-subs to not fail if no subtitles were downloaded
  • either add an option like --embed-subs-if-available or --no-sub-embed-errors to allow this functionality to be enabled conditionally as a user might desire
  • add a more extensible system to allow for logic in applying options based on information about the video

Personally, given the above options, the simplest solution seems very clearly to be the first choice; and, conversely, the third option is clearly the most involved (and may well make youtube-dl turing-complete).

Do any of these options sound reasonable? Is there a way to achieve embedding subs only if they were actually downloaded, and to skip --embed-subs if not (I couldn't find anything in the documentation to suggest so)?

@HalosGhost HalosGhost added the request label Sep 2, 2020
@reallyuniquename
Copy link

@reallyuniquename reallyuniquename commented Sep 2, 2020

if videos do not have subtitles, then it will fail during post-processing

No? It just says There aren't any subtitles to embed and then exits gracefully.

@HalosGhost
Copy link
Author

@HalosGhost HalosGhost commented Sep 3, 2020

@reallyuniquename, there must have been something else wrong with the videos I was downloading as when I ran a test just now, it indeed exited gracefully.

If I figure out that something about the subtitles was indeed related, I'll reopen with more information. Sorry for the noise!

@HalosGhost HalosGhost closed this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.