Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow conditional embedding of subtitles #26504
Comments
No? It just says |
|
@reallyuniquename, there must have been something else wrong with the videos I was downloading as when I ran a test just now, it indeed exited gracefully. If I figure out that something about the subtitles was indeed related, I'll reopen with more information. Sorry for the noise! |
Checklist
Description
I have setup my configuration so that
youtube-dlvery helpfully downloads videos with all my preferred default options. However, one thing I would love to do is add--embed-substo that configuration. I cannot though because, if videos do not have subtitles, then it will fail during post-processing.So, I can imagine three solutions to this:
--embed-substo not fail if no subtitles were downloaded--embed-subs-if-availableor--no-sub-embed-errorsto allow this functionality to be enabled conditionally as a user might desirePersonally, given the above options, the simplest solution seems very clearly to be the first choice; and, conversely, the third option is clearly the most involved (and may well make
youtube-dlturing-complete).Do any of these options sound reasonable? Is there a way to achieve embedding subs only if they were actually downloaded, and to skip
--embed-subsif not (I couldn't find anything in the documentation to suggest so)?