Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed thumbnail still broken? #26589

Closed
lolmc1982 opened this issue Sep 14, 2020 · 2 comments
Closed

embed thumbnail still broken? #26589

lolmc1982 opened this issue Sep 14, 2020 · 2 comments

Comments

@lolmc1982
Copy link

@lolmc1982 lolmc1982 commented Sep 14, 2020

Checklist

  • I'm reporting a broken site support issue
  • I've verified that I'm running youtube-dl version 2020.09.14
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar bug reports including closed ones
  • I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-x', '-f', 'bestaudio', '--audio-format', 'mp3', 'https://www.youtube.com/watch?v=dQw4w9WgXcQ', '-o', 'C:/Users/ASUS/Desktop/Youtube//g/%(title)s.%(ext)s', '--embed-thumbnail', '-c', '-i', '-k']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.09.14
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg git-2020-08-31-4a11a6f, ffprobe git-2020-08-31-4a11a6f
[debug] Proxy map: {}
[youtube] dQw4w9WgXcQ: Downloading webpage
[youtube] {18} signature length 103, html5 player 134332d3
[youtube] {137} signature length 107, html5 player 134332d3
[youtube] {248} signature length 107, html5 player 134332d3
[youtube] {399} signature length 107, html5 player 134332d3
[youtube] {136} signature length 107, html5 player 134332d3
[youtube] {247} signature length 107, html5 player 134332d3
[youtube] {398} signature length 107, html5 player 134332d3
[youtube] {135} signature length 107, html5 player 134332d3
[youtube] {244} signature length 107, html5 player 134332d3
[youtube] {397} signature length 107, html5 player 134332d3
[youtube] {134} signature length 107, html5 player 134332d3
[youtube] {243} signature length 107, html5 player 134332d3
[youtube] {396} signature length 107, html5 player 134332d3
[youtube] {133} signature length 103, html5 player 134332d3
[youtube] {242} signature length 103, html5 player 134332d3
[youtube] {395} signature length 107, html5 player 134332d3
[youtube] {160} signature length 107, html5 player 134332d3
[youtube] {278} signature length 107, html5 player 134332d3
[youtube] {394} signature length 107, html5 player 134332d3
[youtube] {140} signature length 107, html5 player 134332d3
[youtube] {249} signature length 107, html5 player 134332d3
[youtube] {250} signature length 107, html5 player 134332d3
[youtube] {251} signature length 107, html5 player 134332d3
[youtube] dQw4w9WgXcQ: Downloading thumbnail ...
[youtube] dQw4w9WgXcQ: Writing thumbnail to: C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).webp
[debug] Invoking downloader on 'https://r4---sn-8qj-0pie.googlevideo.com/videoplayback?expire=1600109929&ei=CWlfX7ahGYa2s8IP_fy9sAQ&ip=113.184.234.41&id=o-AM5EInVYquMyw4ylLADxKctv_fWeUkVXzE9INarMJUgW&itag=251&source=youtube&requiressl=yes&mh=7c&mm=31%2C29&mn=sn-8qj-0pie%2Csn-8qj-i5oes&ms=au%2Crdu&mv=m&mvi=4&pcm2cms=yes&pl=22&gcr=vn&initcwndbps=1593750&vprv=1&mime=audio%2Fwebm&gir=yes&clen=3438483&dur=212.061&lmt=1578935058552556&mt=1600088205&fvip=4&keepalive=yes&c=WEB&txp=5531432&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cgcr%2Cvprv%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpcm2cms%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhANtkkSAbNUKkA-Zm4M8gevxef3x4uNtjQ9-yE4xkZthMAiEAtPoXzWkXwmzrdatdXT0oHLFcnfA1e0otp0uK-qqmTYA%3D&sig=AOq0QJ8wRQIhAJtZ3S1clPP2EOoLfI8d1jza0Vz6SxS2AX70v3_nLQIMAiBP03fN9X4VzUZ0Cpz_zeZIcQj2kdRpuYLUkz2IOX73lQ==&ratebypass=yes'
[download] C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).webm has already been downloaded
[download] 100% of 3.28MiB
[debug] ffmpeg command line: ffprobe -show_streams "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).webm"
[ffmpeg] Destination: C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).webm" -vn -acodec libmp3lame "-q:a" 5 "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).mp3"
[ffmpeg] Converting thumbnail "C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).webp" to JPEG
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).webp" "-bsf:v" mjpeg2jpeg "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).jpg"
[ffmpeg] Adding thumbnail to "C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).mp3"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).mp3" -i "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).jpg" -c copy -map 0 -map 1 "-metadata:s:v" "title=\"Album cover\"" "-metadata:s:v" "comment=\"Cover (Front)\"" "file:C:\Users\ASUS\Desktop\Youtube\g\Rick Astley - Never Gonna Give You Up (Video).temp.mp3"
Press any key to continue . . .

Description

hmm
it doesnt add thumbnail to mp3 file...
the mp3 file still work
nothing else .-.

@andreamatt
Copy link

@andreamatt andreamatt commented Sep 14, 2020

I get Correcting extension to webp and escaping path for thumbnail .. and it stays there

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Sep 14, 2020

> ffmpeg.exe -i '.\Rick Astley - Never Gonna Give You Up (Video)-dQw4w9WgXcQ.mp3'
...
    Stream #0:1: Video: mjpeg, yuvj420p(pc, bt470bg/unknown/unknown), 1280x720, 90k tbr, 90k tbn, 90k tbc
    Metadata:
      title           : "Album cover"
      comment         : Other
...
@dstftw dstftw closed this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.