Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg merging fails on Python 3.3 #2717

Closed
AGSPhoenix opened this issue Apr 7, 2014 · 1 comment
Closed

ffmpeg merging fails on Python 3.3 #2717

AGSPhoenix opened this issue Apr 7, 2014 · 1 comment

Comments

@AGSPhoenix
Copy link
Contributor

@AGSPhoenix AGSPhoenix commented Apr 7, 2014

python __main__.py https://www.youtube.com/watch?v=inkTOjhftR8 -f 140+160 -v [debug] System config: [] [debug] User config: ['--no-check-certificate', '--no-mtime'] [debug] Command-line args: ['https://www.youtube.com/watch?v=inkTOjhftR8', '-f', '140+160', '-v'] [debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252 [debug] youtube-dl version 2014.04.07 [debug] Python version 3.3.3 - Windows-7-6.1.7601-SP1 [debug] Proxy map: {} [youtube] Setting language [youtube] inkTOjhftR8: Downloading webpage [youtube] inkTOjhftR8: Downloading video info webpage [youtube] inkTOjhftR8: Extracting video information [download] yep thats how walls work-inkTOjhftR8.f140.m4a has already been downloaded [download] yep thats how walls work-inkTOjhftR8.f160.mp4 has already been downloaded [ffmpeg] Merging formats into "yep thats how walls work-inkTOjhftR8.m4a" [debug] ffmpeg command line: ffmpeg -y -i 'yep thats how walls work-inkTOjhftR8.f140.m4a' -i 'yep thats how walls work-inkTOjhftR8.f160.mp4' -c copy 'yep thats how walls work-inkTOjhftR8.m4a' Traceback (most recent call last): File "__main__.py", line 18, in <module> youtube_dl.main() File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\__init__.py", line 837, in main _real_main(argv) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\__init__.py", line 827, in _real_main retcode = ydl.download(all_urls) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\YoutubeDL.py", line 1033, in download self.extract_info(url) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\YoutubeDL.py", line 522, in extract_info return self.process_ie_result(ie_result, download, extra_info) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\YoutubeDL.py", line 559, in process_ie_result return self.process_video_result(ie_result, download=download) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\YoutubeDL.py", line 814, in process_video_result self.process_info(new_info) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\YoutubeDL.py", line 1016, in process_info self.post_process(filename, info_dict) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\YoutubeDL.py", line 1067, in post_process keep_video_wish, new_info = pp.run(info) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\postprocessor\ffmpeg.py", line 484, in run self.run_ffmpeg_multiple_files(info['__files_to_merge'], filename, args) File "C:\Users\Phoenix\Documents\GitHub\youtube-dl\youtube_dl\postprocessor\ffmpeg.py", line 57, in run_ffmpeg_multiple_files p = subprocess.Popen(bcmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) File "C:\Python33\lib\subprocess.py", line 824, in __init__ restore_signals, start_new_session) File "C:\Python33\lib\subprocess.py", line 1071, in _execute_child args = list2cmdline(args) File "C:\Python33\lib\subprocess.py", line 632, in list2cmdline needquote = (" " in arg) or ("\t" in arg) or not arg TypeError: Type str doesn't support the buffer API

Bonus info: bcmd at youtube_dl/postprocessor/ffmpeg.py:56 is a list of bytes objects, not strings

@phihag phihag closed this in 269aecd Apr 7, 2014
@phihag
Copy link
Contributor

@phihag phihag commented Apr 7, 2014

Works fine when passing in strings instead of bytes, fixed in 269aecd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.