Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause/resume/stop functionality #2764

Closed
MrS0m30n3 opened this issue Apr 17, 2014 · 6 comments
Closed

Add pause/resume/stop functionality #2764

MrS0m30n3 opened this issue Apr 17, 2014 · 6 comments

Comments

@MrS0m30n3
Copy link

@MrS0m30n3 MrS0m30n3 commented Apr 17, 2014

I think it would be really useful if you could add pause/resume/stop download functionality on youtube-dl. I tried to implement it you can take a look here: https://github.com/MrS0m30n3/youtube-dl/commit/3d6a61be64e9bde330fc5efa082fbbbe8081013f
I also added an easy to use YoutubeDLExtendedObject with auto command line parsing.

@m13253
Copy link

@m13253 m13253 commented Apr 17, 2014

Just a hint: youtube-dl automatically resumes download if you use the same parameters and the same file name.

@deepesh-agarwal
Copy link

@deepesh-agarwal deepesh-agarwal commented Apr 18, 2014

@MrS0m30n3 How to send the pause/resume/stop commands?

@AGSPhoenix
Copy link
Contributor

@AGSPhoenix AGSPhoenix commented Apr 18, 2014

If you want to pause or stop the download, just press Ctrl-C, and youtube-dl will exit. Run the same command again, and youtube-dl will resume the download where it stopped.

@MrS0m30n3, that's quite a sizable patch, but I've mentioned it in the IRC channel, and someone should take a look at it eventually.

@phihag
Copy link
Contributor

@phihag phihag commented Apr 18, 2014

@MrS0m30n3 If you want code to be integrated into mainline youtube-dl, please submit a pull request. That allows us to discuss and review it together.

@phihag
Copy link
Contributor

@phihag phihag commented Apr 18, 2014

@MrS0m30n3 Looking at the differences, they are huge. Make sure to split up large changes into multiple small (obvious) ones. Additionally, I would strongly discourage splitting youtube-dl into normal and extended - what would you do if someone else has another improvement? Call it advanced?

@phihag
Copy link
Contributor

@phihag phihag commented Apr 19, 2014

I'm closing this issue now, you can simply kill youtube-dl and then re-invoke it.

@phihag phihag closed this Apr 19, 2014
@ytdl-org ytdl-org deleted a comment from douglasg14b Apr 26, 2018
@ytdl-org ytdl-org locked and limited conversation to collaborators Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.