Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event label fields (&el=...) #2916

Closed
0xced opened this issue May 14, 2014 · 1 comment
Closed

Event label fields (&el=...) #2916

0xced opened this issue May 14, 2014 · 1 comment

Comments

@0xced
Copy link
Contributor

@0xced 0xced commented May 14, 2014

The YouTube extractor tries 4 different el types.

I noticed that embedded and detailpage are enough for all the videos I tested. Trying vevo or empty never turned up any result that embedded and detailpage would not get. Is this really necessary to try all four? Can you point me to a video that would work only if trying with vevo or empty?

@phihag
Copy link
Contributor

@phihag phihag commented May 14, 2014

Taking out vevo or '' would do not have an extremely negligible impact on runtime, because the further types are only evaluated once the first two fail. Therefore, why do you think the additional types pose a problem in the first place?

Unfortunately, I cannot find the original issues - I believe they were lost in the move from bitbucket to GitHub (and 787f2a5) doesn't mention an example URL. Since the further tries should not hurt, I don't see any reason for removing them though. If you can present a reason, I'll be happy to remove them.

@phihag phihag closed this May 14, 2014
0xced added a commit to 0xced/XCDYouTubeKit that referenced this issue Sep 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.