Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is `zip` really required to build? #3064

Closed
HalosGhost opened this issue Jun 11, 2014 · 4 comments
Closed

Is `zip` really required to build? #3064

HalosGhost opened this issue Jun 11, 2014 · 4 comments

Comments

@HalosGhost
Copy link

@HalosGhost HalosGhost commented Jun 11, 2014

It seems crazy to me that zip is needed to "build" a project where the source files are available in the repo unarchived. Is this really needed?

@ghost
Copy link

@ghost ghost commented Jun 11, 2014

For linux zip is needed to create one standalone executable file...

All python files are zipped + some python magic = you have youtube-dl in one file, that can be executed and it works :)

Here is the code from Makefile, that make it happen https://github.com/rg3/youtube-dl/blob/master/Makefile#L43-L49

@phihag
Copy link
Contributor

@phihag phihag commented Jun 11, 2014

Yes, this is correct, see http://bugs.python.org/issue1739468 . When building youtube-dl to a single youtube-dl file, we need some way to put all the files into one archive, and Python only supports zip, so zip it is.

You can simply unpack the youtube_dl directory though and then run python -m youtube_dl. However, many users prefer a single-file installation.

@phihag phihag closed this Jun 11, 2014
@ghost
Copy link

@ghost ghost commented Jun 11, 2014

@phihag if i understand it correctly, youtube-dl is extracted everytime we run it? If yes maybe it's the problem of slowness on rpi #3029?

@phihag
Copy link
Contributor

@phihag phihag commented Jun 11, 2014

@pulpe I thought I had commented on that. Yes, that may be one reason, although my previous experiments indicated the main overhead may be Python parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.