Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download from escapist magazine #3557

Closed
ddevault opened this issue Aug 20, 2014 · 3 comments
Closed

Unable to download from escapist magazine #3557

ddevault opened this issue Aug 20, 2014 · 3 comments

Comments

@ddevault
Copy link

@ddevault ddevault commented Aug 20, 2014

sircmpwn@homura ~> youtube-dl --verbose "http://www.escapistmagazine.com/videos/view/zero-punctuation/9664-Sacred-3-Hack-and-Slash-Review"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://www.escapistmagazine.com/videos/view/zero-punctuation/9664-Sacred-3-Hack-and-Slash-Review']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.10
[debug] Python version 3.4.1 - Linux-3.16.1-1-ARCH-x86_64-with-arch
[debug] Proxy map: {}
[Escapist] 9664: Extracting information
[Escapist] 9664: Downloading webpage
ERROR: Unable to extract player URL; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 516, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 170, in extract
    return self._real_extract(url)
  File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/escapist.py", line 39, in _real_extract
    playerUrl = self._og_search_video_url(webpage, name=u'player URL')
  File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 468, in _og_search_video_url
    return self._html_search_regex(regexes, html, name, **kargs)
  File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 401, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags)
  File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 391, in _search_regex
    raise RegexNotFoundError(u'Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract player URL; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
@Tailszefox
Copy link
Contributor

@Tailszefox Tailszefox commented Aug 20, 2014

From what I can tell, this is because _og_search_video_url looks for the meta property "og:video", at line 466:
regexes = self._og_regexes('video')

However, no such property exists on the video webpage (anymore? It worked well not too long ago). Instead, there is an og:video:url property:
<meta property="og:video:url" content="http://cdn2.escapistmagazine.com/media/global/movies/player/flowplayer.commercial-3.2.12.swf?config=http%3A%2F%2Fwww.escapistmagazine.com%2Fvideos%2Fconfig%2F9664-1cb8c909bb45433ca1254499400cc81f.js%3Fembed%3D1%26fb%3D1">

Changing line 466 to the following fixes the issue:
regexes = self._og_regexes('video:url')

 % ./__main__.py http://www.escapistmagazine.com/videos/view/zero-punctuation/9664-Sacred-3-Hack-and-Slash-Review
[Escapist] 9664: Extracting information
[Escapist] 9664: Downloading webpage
[Escapist] 9664: Downloading normal configuration
[Escapist] 9664: Downloading hq configuration
[download] Destination: Sacred 3 - Nothing Is Sacred-9664.mp4
[download] 100% of 7.37MiB in 00:04

I am pretty sure this is going to break websites which are using the "og:video" property instead of "og:video:url" so there's certainly a better way to fix this that wouldn't end up breaking everything else.

@phihag
Copy link
Contributor

@phihag phihag commented Aug 21, 2014

Thank you for the report. This bug has been fixed in youtube-dl 2015.08.21.2. It looks like you have installed youtube-dl with a package manager such as pip or pacman. Use that package manager to update.

@phihag phihag closed this in a368197 Aug 21, 2014
@ddevault
Copy link
Author

@ddevault ddevault commented Aug 21, 2014

Thanks for the speedy fix 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.