Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests & Failing Builds #3683

Closed
ryanmjacobs opened this issue Sep 4, 2014 · 2 comments
Closed

Pull Requests & Failing Builds #3683

ryanmjacobs opened this issue Sep 4, 2014 · 2 comments

Comments

@ryanmjacobs
Copy link

@ryanmjacobs ryanmjacobs commented Sep 4, 2014

As of commit f2d9e3a, nearly all pull requests are failing their Travis CI build.

My pull request #3673 fails. Although the only thing I changed was a line in youtube-dl --help. So, I don't believe that these failures are being caused by bugs in the pull requests.

Does anyone know why the pull requests are failing their builds?

@ryanmjacobs ryanmjacobs changed the title Pull Requests - Failing Builds Pull Requests & Failing Builds Sep 4, 2014
@phihag
Copy link
Contributor

@phihag phihag commented Sep 4, 2014

For youtube-dl, the pass/fail state is unfortunately not of much value. It's much more useful to look into the failures themselves. This is because we support a lot of services and test each and every one.

However, failing tests may also be caused by broken extractors (instead of temporarily failing services) and/or broken/outdated test configurations, so you are very welcome to suggest fixes for those.

@phihag phihag closed this Sep 4, 2014
@ryanmjacobs
Copy link
Author

@ryanmjacobs ryanmjacobs commented Sep 4, 2014

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.