Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need tests. Really. #371

Closed
FiloSottile opened this issue Jul 6, 2012 · 4 comments
Closed

We need tests. Really. #371

FiloSottile opened this issue Jul 6, 2012 · 4 comments
Assignees

Comments

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Jul 6, 2012

This will be far easier as we advance to an API (#152)
Anyway, I think we should put up some green/red tests, let's say a download (video and info) + md5 test for a set of videos. This because we are really prone to regressions and we have broken IEs every month. It would be better to catch them immediately than to wait for bug reports.

Then, also some unit test for some features would be pretty, but that is secondary.

Suggestions on which framework to use (that IMHO should be the more easy/simple/barebones possible)? Or we are better building our own?

P.S. I am using a new tag "broken-IE" in the issue tracker, feel free to delete it if you don't like it. (And tell me if I am too bold!)

@rg3
Copy link
Collaborator

@rg3 rg3 commented Jul 6, 2012

There's a unit testing package in Python:

http://docs.python.org/library/test.html#module-test

@FiloSottile
Copy link
Collaborator Author

@FiloSottile FiloSottile commented Jul 6, 2012

It seemed an overkill and a bit difficult to use seen the lack of an (our) API, but effectively it might be a good fit to test the info_dicts returned by the IEs, and that is what matters.
I will try to implement something in my fork :)

@ghost ghost assigned FiloSottile Sep 27, 2012
@gcmalloc
Copy link
Contributor

@gcmalloc gcmalloc commented Sep 28, 2012

I implemented a little testing example on my fork, I have some issue with the direct call to one of the file downloader.

@FiloSottile
Copy link
Collaborator Author

@FiloSottile FiloSottile commented Oct 30, 2012

We now have them, thanks to @gcmalloc.
They will need expansion (and integration... um... The Travis CI thing @rg3 😈) but this will come with time. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.