Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname is handled case sensitive which is incorrect #394

Closed
jmayer opened this issue Aug 8, 2012 · 2 comments
Closed

Hostname is handled case sensitive which is incorrect #394

jmayer opened this issue Aug 8, 2012 · 2 comments
Assignees

Comments

@jmayer
Copy link

@jmayer jmayer commented Aug 8, 2012

I recently came along the following url:
http://YouTube.com/watch?v=v0BdJmx-yKg
youtube-dl failed. After writing youtube instead of YouTube it worked. This behaviour is not what would happen in a browser: A browser would just load the url, as (dns-)names are case insensitive per RFC.
youtube-dl isn't respecting that.

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Aug 19, 2012

Python does not support selective flags, so no hostname-only case-insensitiveness.
What about making all the regexs case-insensitive?
I can't see any issue with that ATM...
@phihag ?

@phihag
Copy link
Contributor

@phihag phihag commented Sep 27, 2012

It will be a pain the but to add that for all host names, particularly because in some cases, the rest of the URL may not be case-insensitive. Looking at all our extractors, they all seem to have ASCII-only domains. Therefore, we could do a simple case folding beforehand (and if necessary add the IDN support later). I'm looking into it, but patches are always welcome.

@phihag phihag closed this Sep 27, 2012
@ghost ghost assigned phihag Sep 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.