Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Automatically extract ASS subs when available #4019
Closed
Comments
jaimeMF
added a commit
that referenced
this issue
Oct 29, 2014
Parse the xml document instead of using regexes, otherwise unicode characters are left unescaped.
Merged
|
Thanks for the suggestion, it will work with the syntax you proposed in the next version (and in the case of crunchyroll it will default to ass). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(See #4003 for context)
We currently have to know beforehand if we want to have ASS subs, which requires a site-specific check, which we'd like to avoid. It would be good if ytdl would output ASS subs by default when available (in the case of CR, the SRT subs are completely broken anyway), or if it would be possible to specify an order of prefered formarts, just like for video:
--sub-format=ass/srt