Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tosh.0 on Comedy Central #4098

Closed
ballbeam opened this issue Nov 4, 2014 · 2 comments
Closed

Tosh.0 on Comedy Central #4098

ballbeam opened this issue Nov 4, 2014 · 2 comments

Comments

@ballbeam
Copy link

@ballbeam ballbeam commented Nov 4, 2014

Hi,
I'm pretty new to youtube-dl but it's been amazing so far.
I've successfully managed to download from both thedailyshow.cc.com and thecolbertreport.cc.com but whenever I try to download from tosh.cc.com I get this:

youtube-dl http://tosh.cc.com/full-episodes/tvm4tb/october-28--2014---kayak
[generic] october-28--2014---kayak: Requesting header
WARNING: Falling back on generic information extractor.
[generic] october-28--2014---kayak: Downloading webpage
[generic] october-28--2014---kayak: Extracting information
[download] Destination: October 28, 2014 - Kayak - Tosh.0 -  Full Episode _ Comedy Central-mgid -arc -episode -tosh.comedycentral.unknown_video
[download] 100% of 1.39KiB in 00:00

Any ideas?

@ballbeam
Copy link
Author

@ballbeam ballbeam commented Nov 11, 2014

Hi James! Thanks for replying to my issue.

I added the proper changes to the regex in comedycentral.py and found that it is not downloading because the webpage requires a login. It works fine with the clips that do not require loging-in.

youtube-dl http://tosh.cc.com/video-clips/7cwd41/video-breakdown---purse-robbery --verbose
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['http://tosh.cc.com/video-clips/7cwd41/video-breakdown---purse-robbery', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.11.04
[debug] Python version 2.7.6 - Darwin-14.0.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 2.4.2, ffprobe 2.4.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] video-breakdown---purse-robbery: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video-breakdown---purse-robbery: Downloading webpage
[generic] video-breakdown---purse-robbery: Extracting information
[debug] Invoking downloader on u'http://media.mtvnservices.com/embed/mgid:arc:video:tosh.comedycentral.com:e27ff518-ffbb-4328-906b-34b8b98775c4'
[download] Video Breakdown - Purse Robbery - Video Clip _ Tosh.0 _ Comedy Central-mgid -arc -video -tosh.comedycentral.unknown_video has already been downloaded

I would think so too but here’s what happens to me when I try to download a non-login clip.

While I know my way around the command line okay by now, that last part about patches just got me very confused. But if I get this straight, I need to replace the comedycentral.py you pasted down below with my old one, just updating won’t do the trick?

Thanks,
Isaac

8 nov 2014 kl. 17:23 skrev James-Brosnahan notifications@github.com:

I added the proper changes to the regex in comedycentral.py and found that it is not downloading because the webpage requires a login. It works fine with the clips that do not require loging-in.
Here is a patch of the change. I don't know too much about the flow of youtube-dl but will try to add support for the login if I get around to it. The error I get on "http://tosh.cc.com/full-episodes/tvm4tb/october-28--2014---kayak http://tosh.cc.com/full-episodes/tvm4tb/october-28--2014---kayak" is:

python -m youtube_dl "http://tosh.cc.com/full-episodes/tvm4tb/october-28--2014---kayak http://tosh.cc.com/full-episodes/tvm4tb/october-28--2014---kayak" --verbose

[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['http://tosh.cc.com/full-episodes/tvm4tb/october-28--2014---kayak http://tosh.cc.com/full-episodes/tvm4tb/october-28--2014---kayak', '--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.11.04
[debug] Git HEAD: 29ed169 29ed169
[debug] Python version 2.7.3 - Linux-3.2.0-23-generic-pae-i686-with-Ubuntu-12.04-precise
[debug] exe versions: avconv 0.8.15-4, avprobe 0.8.15-4, ffmpeg 0.8.15-4, ffprobe 0.8.15-4, rtmpdump 2.4
[debug] Proxy map: {}
[ComedyCentralShows] october-28--2014---kayak: Downloading webpage
[ComedyCentralShows] october-28--2014---kayak: Downloading show index
[ComedyCentralShows] october-28--2014---kayak: Downloading configuration for segment 1 / 5
[ComedyCentralShows] october-28--2014---kayak: Downloading configuration for segment 2 / 5
[ComedyCentralShows] october-28--2014---kayak: Downloading configuration for segment 3 / 5
[ComedyCentralShows] october-28--2014---kayak: Downloading configuration for segment 4 / 5
[ComedyCentralShows] october-28--2014---kayak: Downloading configuration for segment 5 / 5
[download] Downloading playlist: tosh October 28, 2014 - Kayak
[ComedyCentralShows] playlist tosh October 28, 2014 - Kayak: Collected 5 video ids (downloading 5 of them)
[download] Downloading video #1 #1 of 5
ERROR: No video formats found!; please report this issue on https://yt-dl.org/bug https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type youtube-dl -U to update.
Traceback (most recent call last):
File "youtube_dl/YoutubeDL.py", line 547, in extract_info
return self.process_ie_result(ie_result, download, extra_info)
File "youtube_dl/YoutubeDL.py", line 675, in process_ie_result
extra_info=extra)
File "youtube_dl/YoutubeDL.py", line 593, in process_ie_result
return self.process_video_result(ie_result, download=download)
File "youtube_dl/YoutubeDL.py", line 783, in process_video_result
raise ExtractorError('No video formats found!')
ExtractorError: No video formats found!; please report this issue on https://yt-dl.org/bug https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type youtube-dl -U to update.

since the patch did not attach; here's the txt from it:

--- comedycentral.py.old 2014-11-08 11:15:48.654633599 -0500
+++ comedycentral.py 2014-11-08 11:12:27.850642551 -0500
@@ -40,16 +40,16 @@

or: http://www.colbertnation.com/the-colbert-report-collections/422008/festival-of-lights/79524 http://www.colbertnation.com/the-colbert-report-collections/422008/festival-of-lights/79524

_VALID_URL = r'''(?x)^(:(?Ptds|thedailyshow|cr|colbert|colbertnation|colbertreport)
|https?://(:www.)?

(?Pthedailyshow|thecolbertreport).(?:cc.)?com/
(?Pthedailyshow|thecolbertreport|tosh).(?:cc.)?com/ ((?:full-)?episodes/(?:[0-9a-z]{6}/)?(?P.)| (?P
(?:(?:guests/[^/]+|videos|video-playlists|special-editions|news-team/[^/]+)/[^/]+/(?P[^/?#]+))
(?:(?:guests/[^/]+|videos|video-playlists|special-editions|video-clips|news-team/[^/]+)/[^/]+/(?P[^/?#]+)) |(the-colbert-report-(videos|collections)/(?P[0-9]+)/[^/]/(?P.?)) |(watch/(?P[^/])/(?P.)) )| (?P extended-interviews/(?P[0-9a-z]+)/(?:playlist_tds_extended
)?(?P.?)(/.?)?)))
(?:[?#]._|$)'''
(?:[?#].*|$)''' #http://tosh.cc.com/video-clips/1bxb4s/paint-scream http://tosh.cc.com/video-clips/1bxb4s/paint-scream _TESTS = [{ 'url': 'http://thedailyshow.cc.com/watch/thu-december-13-2012/kristen-stewart http://thedailyshow.cc.com/watch/thu-december-13-2012/kristen-stewart', 'md5': '4e2f5cb088a83cd8cdb7756132f9739d', @@ -243,4 +243,3 @@ 'title': show_name + ' ' + title, 'description': description, } -

Reply to this email directly or view it on GitHub https://github.com//issues/4098#issuecomment-62263604.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 22, 2016

tosh.cc.com will be supported in the next version.

@dstftw dstftw closed this May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jaimeMF @dstftw @ballbeam and others
You can’t perform that action at this time.