Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NiconicoPlaylist gives wrong %(url)s #4133

Closed
ponyo opened this issue Nov 8, 2014 · 2 comments
Closed

NiconicoPlaylist gives wrong %(url)s #4133

ponyo opened this issue Nov 8, 2014 · 2 comments

Comments

@ponyo
Copy link

@ponyo ponyo commented Nov 8, 2014

Currently, videos in a playlist use alternative URL's to the links given on the site. This is relevant when using the -o option so I think that it would be better to change it in order to be consistent. That would mean using entry['item_data']['video_id'] instead of entry['item_id'] in this line of code:

https://github.com/rg3/youtube-dl/blob/6110bbbfdd6418950beaf487e5a384cc7c483498/youtube_dl/extractor/niconico.py#L178

@jaimeMF jaimeMF closed this in 2fdbf27 Nov 8, 2014
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Nov 8, 2014

It will use the same urls as the site in the next version.

@ponyo
Copy link
Author

@ponyo ponyo commented Nov 9, 2014

Thanks for the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.