Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
UnicodeDecodeError; downloads OK, can't mux #4337
Comments
|
I'm not familiar with python but I think it's because of mixed encoding in arguments passed to subprocess.Popen(). --- ffmpeg.py.old Sat Dec 13 10:09:45 2014 files_cmd = []
for path in input_paths:
- files_cmd.extend(['-i', encodeFilename(path, True)])
- cmd = ([self._executable, '-y'] + files_cmd
+ files_cmd.extend([encodeArgument('-i'), encodeFilename(path, True)])
+ cmd = ([encodeArgument(self._executable), encodeArgument('-y')] + files_cmd
+ [encodeArgument(o) for o in opts] +
[encodeFilename(self._ffmpeg_filename_argument(out_path), True)])I know there should be more polite and simple way. |
|
I have the same error when download video with Chinese title, such as
|
|
@imjacklai diff --git a/youtube_dl/postprocessor/ffmpeg.py b/youtube_dl/postprocessor/ffmpeg.py raise PostProcessingError('ffprobe or avprobe not found. Please install one.')
try:
cmd = [
- self._probe_executable,
- '-show_streams',
+ encodeFilename(self._probe_executable, True),
+ encodeArgument('-show_streams'),
encodeFilename(self._ffmpeg_filename_argument(path), True)]
handle = subprocess.Popen(cmd, stderr=compat_subprocess_get_DEVNULL(), stdout=subprocess.PIPE)
output = handle.communicate()[0] |
|
Thank you for the report! I believe this issue to be fixed in youtube-dl 2015.01.09 and newer. See our FAQ if you need help updating. |
last working version is 2014.11.26