Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a bug in extractor sohu.py #4409

Closed
horidream opened this issue Dec 8, 2014 · 1 comment
Closed

Found a bug in extractor sohu.py #4409

horidream opened this issue Dec 8, 2014 · 1 comment

Comments

@horidream
Copy link

@horidream horidream commented Dec 8, 2014

[line 58]
vid_id = vid_ids[-1]
should be
vid_id = vid_ids[0]
to download best quality video by default

@iggyvolz
Copy link

@iggyvolz iggyvolz commented Dec 10, 2014

You can submit a pull request for this so that the test suite runs and it's easier to check and make sure the change is correct. Just click "edit" on the file in question, change the line, and add a commit message at the bottom. It will automatically link you to the "Pull Request" window where you can make a pull request, which is very similar to an issue. Make sure to add the phrase "fixes #4409" somewhere in your pull request so the pull request links to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.