Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken IE : Dailymotion. (Pull request) #446

Closed
Steap opened this issue Sep 30, 2012 · 2 comments
Closed

Broken IE : Dailymotion. (Pull request) #446

Steap opened this issue Sep 30, 2012 · 2 comments

Comments

@Steap
Copy link
Contributor

@Steap Steap commented Sep 30, 2012

Hello !

The Dailymotion IE got fixed yesterday, but still fails on some videos. I wrote two patches that should fix this issue :

They can be pulled from git://gitorious.org/youtube-dl/youtube-dl.git

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Sep 30, 2012

Great! Thanks a lot.

I modified the extraction of the video_id as now it would be anything after /video/, like xtqu82_winamax-poker-open-le-streaming-en-live-29-et-30-septembre_sport?no_track=1 in this case. I made it to look for the part before any _ or ?:

video_id = mobj.group(1).split('_')[0].split('?')[0]

Let me know if you think this is not good.
Thanks again, bye.

@Steap
Copy link
Contributor Author

@Steap Steap commented Sep 30, 2012

Looks good to me.

Thanks for your quick answer, and keep up the good work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.