Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC iPlayer Embeds #4619

Closed
epitron opened this issue Jan 2, 2015 · 3 comments
Closed

BBC iPlayer Embeds #4619

epitron opened this issue Jan 2, 2015 · 3 comments

Comments

@epitron
Copy link
Contributor

@epitron epitron commented Jan 2, 2015

Hi there!

The BBC iPlayer extractor (bbccouk.py) currently doesn't handle embedded videos. There are a few examples on this page: http://www.bbc.co.uk/blogs/adamcurtis/posts/BUGGER

It looks like it should be simple to add: the <param flashvars="..."> tag (inside the embed's <div class="player"> tag) has an iPlayer url in it. I can paste it right into youtube-dl, and it downloads fine! The extractor just needs to recognize those embeds and scrape out the URL (the flashvar that contains the URL is called "playlist").

(BTW: To make youtube-dl download the url from the flash variable, I had to update the _VALID_URL regexp to accept "iplayer/playlist" urls, like this: _VALID_URL = r'https?://(?:www\.)?bbc\.co\.uk/(?:programmes|iplayer/episode|iplayer/playlist)/(?P<id>[\da-z]{8})')

What's a good way to implement this? Is there an extractor that I can take a look at as a good example?

Thanks!

@dstftw dstftw closed this in db546cf Jan 2, 2015
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Jan 2, 2015

BBC iPlayer embeds will be supported in the next version. Thanks for the report.

@epitron
Copy link
Contributor Author

@epitron epitron commented Jan 3, 2015

Great! Thanks for the fast response.

@phihag
Copy link
Contributor

@phihag phihag commented Jan 6, 2015

I believe this issue to be fixed in youtube-dl 2015.01.05 or newer. See our FAQ if you need help updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.