Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should distinguish avconv/ffmpeg with -version #463

Closed
FiloSottile opened this issue Oct 8, 2012 · 4 comments
Closed

We should distinguish avconv/ffmpeg with -version #463

FiloSottile opened this issue Oct 8, 2012 · 4 comments

Comments

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Oct 8, 2012

This is a low priority, but is the only solution to the symlinks mess that are some current distribution packages.

@phihag
Copy link
Contributor

@phihag phihag commented Oct 9, 2012

Sorry, I don't understand this issue. What exactly is the problem of symlinked versions of aconv/ffmpeg? And why can't we simply use the ffmpeg binary when it's there, and avconv if it's not?

@FiloSottile
Copy link
Collaborator Author

@FiloSottile FiloSottile commented Oct 9, 2012

For example in Ubuntu, ffmpeg is a symlink to avconv. At the moment we are handling this simply giving priority to ffmpeg, but one can have the opposite situation on a system, and we would consider avconv as ffmpeg then. And we can't ignore symlinks as they are common in $PATH. Maybe following them and looking at the original executable name?

@phihag
Copy link
Contributor

@phihag phihag commented Oct 9, 2012

Oh, I think I misunderstood; I didn't realize the APIs of aconv and ffmpeg differ. Isn't there a common subset we can use?

In any case, that's not a problem by convention: If the user (or the distribution) implements ffmpeg with a symlink to another program, that other program better accept ffmpeg-style arguments.

Therefore, instead of trying to go down the rabbit hole of how one program may call another (what if ffmpeg is a shell program exec avconv "$@"? What if it's a hardlink? ...), we should take care to restrict our arguments to what is widely accepted, and report bugs to the distributions (say, if ffmpeg foo.mp3 -i foo.mp4 suddenly fails because they decided to symlink ffmpeg to mencoder).

@phihag phihag closed this Oct 9, 2012
@FiloSottile
Copy link
Collaborator Author

@FiloSottile FiloSottile commented Oct 9, 2012

Unfortunately, a couple of things we use are actually incompatibile. Will have to check better, thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.